Skip to content

Fix false "never constructed" warnings for Self:: variant paths - #71026

Merged
bors merged 2 commits into
rust-lang:masterfrom
seiyab:issue-64362-adhoc
Apr 19, 2020
Merged

Fix false "never constructed" warnings for Self:: variant paths#71026
bors merged 2 commits into
rust-lang:masterfrom
seiyab:issue-64362-adhoc

Conversation

@seiyab

@seiyabseiyab commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

Closes#64362 .

@rust-highfive

rust-highfive commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2020
@seiyabseiyab mentioned this pull request Apr 11, 2020
Closed
@seiyab

seiyab commented Apr 19, 2020

Copy link
Copy Markdown
ContributorAuthor

What CI / PR does?
I can neither read detail log nor find docs.

@varkor

varkor commented Apr 19, 2020

Copy link
Copy Markdown
Contributor

@seiyab: huh, I'm actually not sure why those tests failed. There seemed to be no log attached, as you say. I've restarted them, so hopefully they'll work properly this time.

@seiyab

seiyab commented Apr 19, 2020

Copy link
Copy Markdown
ContributorAuthor

They have a trouble to check out the code...
They check out to 01a37fef4bf59d4a3adac9b32b1cbc6197a5332a rather than refs/pull/71026/merge .
I don't know the reason.

@varkor

varkor commented Apr 19, 2020

Copy link
Copy Markdown
Contributor

Maybe you could try rebasing on top of the current master? If this doesn't work, I'll investigate further.

@seiyab

seiyab commented Apr 19, 2020

Copy link
Copy Markdown
ContributorAuthor

@varkor
Thank you to restart pipelines and friendly advice.
I'll try rebasing.

@seiyab

seiyab commented Apr 19, 2020

Copy link
Copy Markdown
ContributorAuthor

@varkor
Your advice helps.
CI / PR (x86_64-gnu-tools) succeeded.
Thank you very much 😄

@varkor

varkor commented Apr 19, 2020

Copy link
Copy Markdown
Contributor

@seiyab: thanks for the fix!

@bors r+ rollup

@bors

bors commented Apr 19, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d3f8db6 has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2020
@bors
Auto merge ofrust-lang#71331- Dylan-DPC:rollup-5rn1isc, r=Dylan-DPC
dbf8b6b
Rollup of 4 pull requests
Successful merges:
- rust-lang#71026 (Fix false "never constructed" warnings for `Self::` variant paths)
- rust-lang#71310 (Do not show DefId in diagnostics)
- rust-lang#71317 (miri-unleash test for llvm_asm)
- rust-lang#71324 (Fix some tests failing in `--pass check` mode)
Failed merges:
r? @ghost
@bors
bors merged commit 9c5da9a into rust-lang:masterApr 19, 2020
@seiyab
seiyab deleted the issue-64362-adhoc branch April 20, 2020 00:03
@seiyab

seiyab commented Apr 20, 2020

Copy link
Copy Markdown
ContributorAuthor

@varkor
Thank you for your review and merging.
I'm very happy and proud of contributing Rust, that I like 😆

@LonamiLonami mentioned this pull request Apr 24, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@varkorvarkor

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"variant is never constructed" lint appears to be incorrect?

5 participants

@seiyab@rust-highfive@varkor@bors@jakubadamw