Uh oh!
There was an error while loading. Please reload this page.
[experiment] ty/layout: compute both niche-filling and tagged layouts for enums. - #71045
[experiment] ty/layout: compute both niche-filling and tagged layouts for enums.#71045eddyb wants to merge 1 commit into
Conversation
rust-highfive
commented
Apr 11, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Apr 11, 2020
@bors try @rust-timer queue |
rust-timer
commented
Apr 11, 2020
Awaiting bors try build completion |
bors
commented
Apr 11, 2020
⌛ Trying commit 13c200a with merge 9a594eaf4326233bc29fe01ece3e52c2a0406229... |
bors
commented
Apr 12, 2020
☀️ Try build successful - checks-azure |
rust-timer
commented
Apr 12, 2020
Queued 9a594eaf4326233bc29fe01ece3e52c2a0406229 with parent e82734e, future comparison URL. |
rust-timer
commented
Apr 12, 2020
Finished benchmarking try commit 9a594eaf4326233bc29fe01ece3e52c2a0406229, comparison URL. |
bjorn3
commented
Apr 12, 2020
There doesn't seem to be any perf difference between master and this PR. |
petrochenkov
commented
Apr 12, 2020
r? @RalfJung |
RalfJung
commented
Apr 12, 2020
I'm afraid I don't know this code nearly well enough to do reviews. I'd have suggested @eddyb until I saw they are the PR author. ;) |
eddyb
commented
Apr 12, 2020
This is only for the perf test 📈. If we did land this, we'd add a comparison between the two layouts, and pick the one that has smaller size, or more invalid values in the |
Muirrum
commented
Jun 20, 2020
@rustbot modify labels to +S-waiting-on-review -S-waiting-on-author |
RalfJung
commented
Jun 28, 2020
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixesrust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixesrust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixesrust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
eddyb
commented
Jul 18, 2020
Thanks to @erikdesjardins, this was finished as #74069. |
Original message: Rollup merge of rust-lang#74069 - erikdesjardins:bad-niche, r=nikomatsakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixesrust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
This is something I've wanted to do for a while, since if we can get away with it perf-wise, it should allow us to always pick the better of the two, even when the conditions would be otherwise subtle.