Uh oh!
There was an error while loading. Please reload this page.
Fix typo in Default trait docs: Provides -> Provide - #71225
Conversation
An earlier commit (99ed06e) accidentally changed this paragraph from the original, imperative "Provide" to the present tense "Provides". The latter is indeed the standard for Rustdoc comments relating to a function or method, but this snippet is introducing the Default trait in general terms and not talking about any particular function. I believe this change was likely made in error and should be reverted.
rust-highfive
commented
Apr 16, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
jonas-schievink
commented
Apr 16, 2020
Thanks! @bors r+ rollup |
bors
commented
Apr 16, 2020
📌 Commit da48550 has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#70578 (Add long error explanation for E0657) - rust-lang#70910 (Hides default fns inside Fuse impl to avoid exposing it to any crate) - rust-lang#71164 (reword Miri validity errors: undefined -> uninitialized) - rust-lang#71182 (Add some regression tests) - rust-lang#71206 (Miri error messages: avoid try terminology) - rust-lang#71220 (Dogfood or_patterns in the standard library) - rust-lang#71225 (Fix typo in Default trait docs: Provides -> Provide) Failed merges: r? @ghost
An earlier commit (99ed06e) accidentally changed this paragraph from the original, imperative
Provideto the present tenseProvides. The latter is indeed the standard for Rustdoc comments relating to a function or method, but this snippet is introducing theDefaulttrait in general terms and not talking about any particular function. I believe this change was likely made in error and should be reverted.