Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #71255
Merged
Merged
Conversation
1. Fixed doc comment of struct 'rustc_middle::mir::Location' Currently, the general explanation of the struct appears at the field explanation section. I moved and changed the doc comments slightly, so that the general explanation would appear in the proper location in docs. 2. Added doc comment explaining 'rustc_mir::util::pretty::write_mir_fn' Unlike other counterparts, brief explanation for this function was missing, so I added one. Thank you for reviewing this PR :)
Use query to determine whether function needs const checking Resolvesrust-lang#69615. The HIR const-checker was checking the `constness` of a function's `fn_sig` to determine whether a function needed const-checking. Now that const trait impls are a thing, this is no longer enough. All code should use the `is_const_fn_raw` query instead, which takes the constness of the impl block into account. r? @oli-obk
Rename `asm` test directory in favor of `llvm_asm` r? @Amanieu
Implement `Clone` for `liballoc::collections::linked_list::Cursor`. This implements `Clone` for linked list `Cursor`. Implementing `Copy` is also possible here, but i'm not sure whether i should also do it. r? @Amanieu
Remove unnecessary variable intialization Minor fix.
Minor fix and addition to doc comments 1. Fixed doc comment of struct 'rustc_middle::mir::Location' Currently, the general explanation of the struct appears at the field explanation section. I moved and changed the doc comments slightly, so that the general explanation would appear in the proper location in docs. 2. Added doc comment explaining 'rustc_mir::util::pretty::write_mir_fn' Unlike other counterparts, brief explanation for this function was missing, so I added one. Thank you for reviewing this PR :)
Dylan-DPC-zz
commented
Apr 17, 2020
Author
@bors r+ rollup=never p=5 |
bors
commented
Apr 17, 2020
Collaborator
📌 Commit 4132642 has been approved by |
bors
commented
Apr 17, 2020
Collaborator
bors
commented
Apr 17, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
asmtest directory in favor ofllvm_asm#71239 (Renameasmtest directory in favor ofllvm_asm)Cloneforliballoc::collections::linked_list::Cursor. #71246 (ImplementCloneforliballoc::collections::linked_list::Cursor.)Failed merges:
r? @ghost