Uh oh!
There was an error while loading. Please reload this page.
Conversation
rust-highfive
commented
Apr 18, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Apr 18, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Dylan-DPC-zz
commented
Apr 19, 2020
Dylan-DPC-zz
commented
Apr 19, 2020
We do not allow merge commits, kindly rebase and re-commit the change :) |
Uh oh!
There was an error while loading. Please reload this page.
ghost
commented
Apr 19, 2020
thank you and done |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
commented
Apr 21, 2020
After a discussion with @xliiv, I got a better understanding of why they were using /// Text/// [Link][Self::foo]////// ```/// // We are inside a trait implementation/// let x = &array[foo][Self::x];/// ```
I thought about two solutions to handle this:
Now that I think about it, when you declare a trait or even a struct, I think that |
This makes sense more to me, so the solution would be to
this should just work now AFAIK (see #70802) @GuillaumeGomez if you can hint me where is the right place to store |
ghost
commented
Apr 21, 2020
Btw, this example data |
ghost
commented
Apr 21, 2020
TODO: check fields too thanks to @GuillaumeGomez |
Dylan-DPC-zz
commented
Apr 21, 2020
@xliiv we do not allow merge commits. can you rebase instead? thanks |
Self:: in doc of methods Self:: in doc of methods
@Dylan-DPC |
Dylan-DPC-zz
commented
Apr 21, 2020
I understand, but it is easier fixing it now with lesser commits than when you have more commits to rebase :D |
Self:: in doc of methods Self:: in doc of methods rust-highfive
commented
Apr 21, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Apr 30, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
May 5, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ghost
commented
May 14, 2020
Blocked by #72173 |
rust-highfive
commented
May 14, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
GuillaumeGomez
commented
May 14, 2020
Please ping me once #72173 is merged (and please rebase at that time so the CI can pass too!) so I can review with everything ready. :) |
Uh oh!
There was an error while loading. Please reload this page.
ghost
commented
May 15, 2020
@GuillaumeGomez done and ready for review :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Looks all good to me! Just the newly added feature that seems weird.
GuillaumeGomez
commented
May 22, 2020
My question has been answered, therefore we can move forward. Thanks a lot for implementing it! @bors: r+ |
bors
commented
May 22, 2020
📌 Commit 94cf2c69dba94a74b0847749595f522a8a73e95b has been approved by |
RalfJung
commented
May 22, 2020
@bors rollup |
ghost
commented
May 22, 2020
Also it could be replaced with |
GuillaumeGomez
commented
May 22, 2020
@bors: r+ |
bors
commented
May 22, 2020
📌 Commit fc0675b has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#71289 (Allow using `Self::` in doc) - rust-lang#72375 (Improve E0599 explanation) - rust-lang#72385 (Add some teams to prioritization exclude_labels) - rust-lang#72395 (Allow rust-highfive to label issues it creates.) - rust-lang#72453 (Add flag to open docs: x.py doc --open) - rust-lang#72459 (Add core::future::IntoFuture) - rust-lang#72461 (Clean up E0600 explanation) Failed merges: r? @ghost
Closes#70802