Skip to content

Suggest adding super trait constraints - #71451

Merged
bors merged 4 commits into
rust-lang:masterfrom
estebank:suggest-super-trait-constraint
May 13, 2020
Merged

Suggest adding super trait constraints#71451
bors merged 4 commits into
rust-lang:masterfrom
estebank:suggest-super-trait-constraint

Conversation

@estebank

@estebankestebank commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@estebank

estebank commented Apr 24, 2020

Copy link
Copy Markdown
ContributorAuthor

The first commit is the only logic change. The second change only changes the output to be more verbose and clear.

@crlf0710crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2020
@bors

This comment has been minimized.

Sign in to view
@estebank
estebankforce-pushed the suggest-super-trait-constraint branch from 9ed0197 to cbaff49CompareMay 7, 2020 00:26
@estebank

estebank commented May 7, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @nikomatsakis

@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
estebankforce-pushed the suggest-super-trait-constraint branch from cbaff49 to 9c539dcCompareMay 7, 2020 19:54
nikomatsakis
nikomatsakis approved these changes May 11, 2020
View reviewed changes
Comment threadsrc/librustc_trait_selection/traits/error_reporting/suggestions.rs Outdated
Comment threadsrc/librustc_trait_selection/traits/error_reporting/suggestions.rs Outdated
Comment threadsrc/librustc_trait_selection/traits/error_reporting/suggestions.rs Outdated
@nikomatsakis

nikomatsakis commented May 11, 2020

Copy link
Copy Markdown
Contributor

r=me with nits

@nikomatsakisnikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2020
@estebank
estebankforce-pushed the suggest-super-trait-constraint branch from 9c539dc to 58797b0CompareMay 12, 2020 18:56
@estebank

estebank commented May 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented May 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 58797b0 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2020
@bors

bors commented May 13, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 58797b0 with merge 750db09...

@bors

bors commented May 13, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: nikomatsakis
Pushing 750db09 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2020
@bors
bors merged commit 750db09 into rust-lang:masterMay 13, 2020
This was referenced May 13, 2020
Closed
Merged
Closed
@estebank
estebank deleted the suggest-super-trait-constraint branch November 9, 2023 05:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@estebank@rust-highfive@bors@nikomatsakis@eddyb@crlf0710