Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #71483
Merged
Merged
Conversation
…ng delimiter rust-lang#70583" This reverts commit 811d817.
…t properly closed block.
Only the "first" iterator is actually set `None` when exhausted, depending on whether you iterate forward or backward. This restores behavior similar to the former `ChainState`, where it would transition from `Both` to `Front`/`Back` and only continue from that side. However, if you mix directions, then this may still set both sides to `None`, totally fusing the iterator.
Confusing suggestion on incorrect closing `}`
Compiler returns
```
error: unexpected closing delimiter: `}`
--> main.rs:20:1
|
9 | ErrorHandled::Reported => {}
| -- this block is empty, you might have not meant to close it temp
...
20 | }
| ^ unexpected closing delimiter
error: aborting due to previous error
```Don't fuse Chain in its second iterator Only the "first" iterator is actually set `None` when exhausted, depending on whether you iterate forward or backward. This restores behavior similar to the former `ChainState`, where it would transition from `Both` to `Front`/`Back` and only continue from that side. However, if you mix directions, then this may still set both sides to `None`, totally fusing the iterator. Fixesrust-lang#71375 r? @scottmcm
…gs, r=kinnison Check code blocks tags Fixesrust-lang#71347. Explanations here: I realized recently that it was a common issue to confuse/misspell tags on code blocks. This is actually quite a big issue since it generally ends up in a code blocks being ignored since it's not being considered as a rust one. With this new warning, users will at least be notified about it. PS: some improvements can be done on the error rendering but considering how big the PR already is, I think it's better to do it afterwards. r? @ollie27 cc @rust-lang/rustdoc
…nieu Add a "by reference" adaptor for `AllocRef` Fixesrust-lang/wg-allocators#53 r? @Amanieu
Only use read_unaligned in transmute_copy if necessary I've noticed that this causes LLVM to generate poor code on targets that don't support unaligned memory accesses.
…evink Fix doc links This fixes a few doc links which were causing `cargo doc` to fail when using `--document-private-items --document-hidden-items` on libstd. Most of the fixes are just escaping '[' and ']' characters in doc comments, and one change actually fixes a doc link.
…chievink add back Scalar::null_ptr We were a bit overeager with removing this in rust-lang#71005, Miri uses this function quite a bit. The important part is that the `Place::null` methods are gone. :) r? @jonas-schievink@oli-obkFixesrust-lang#71474
Dylan-DPC-zz
commented
Apr 23, 2020
Author
@bors r+ p=7 rollup=never |
bors
commented
Apr 23, 2020
Collaborator
📌 Commit b107eb5 has been approved by |
bors
commented
Apr 23, 2020
Collaborator
bors
commented
Apr 23, 2020
Collaborator
☀️ Test successful - checks-azure |
Merged
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 23, 2020
Tested on commit rust-lang/rust@14b1552. Direct link to PR: <rust-lang/rust#71483> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk@eddyb@RalfJung). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk@eddyb@RalfJung).
This was referenced Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
}#70633 (Confusing suggestion on incorrect closing})AllocRef#71442 (Add a "by reference" adaptor forAllocRef)Failed merges:
r? @ghost