Uh oh!
There was an error while loading. Please reload this page.
Fix off by one in treat err as bug - #71489
Conversation
c9f20d6 to
022068eCompareebe48ec to
229970dCompare@eddyb this is ready to review. Unsure if you prefer this strategy or avoid calling Anyway this seems a bit fragile IMO. |
rust-highfive
commented
Apr 24, 2020
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
b52f584 to
08fef9dComparespastorino
commented
Apr 24, 2020
All this is undertested and my guess is that there are more errors like this one. I've created #71531 to move the only treat-err-as-bug test we have to ui tests but also to discuss the best approach to test this and maybe after merging that one we could start adding more treat-err-as-bug tests. |
delay_span_bug bumps error_count after checking treat_err_as_bug
08fef9d to
0cba5a6Compare0cba5a6 to
3fe2804Comparespastorino
commented
Apr 27, 2020
@eddyb fixed the test |
eddyb
commented
Apr 27, 2020
@bors r+ |
bors
commented
Apr 27, 2020
📌 Commit 3fe2804 has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#71311 (On `FnDef` type annotation suggestion, use fn-pointer output) - rust-lang#71488 (normalize field projection ty to fix broken MIR issue) - rust-lang#71489 (Fix off by one in treat err as bug) - rust-lang#71585 (remove obsolete comment) - rust-lang#71634 (Revert rust-lang#71372 ("Fix #! (shebang) stripping account space issue").) Failed merges: r? @ghost
-Ztreat-err-as-bugdoesn't work properly with delay_span_bug.r? @eddyb