Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #71491
Closed
Dylan-DPC-zz wants to merge 22 commits into
Closed
Conversation
Co-authored-by: Mark-Simulacrum <mark.simulacrum@gmail.com>
Co-Authored-By: Mark-Simulacrum <mark.simulacrum@gmail.com>
…gnostic, r=estebank Make the `structural_match` error diagnostic for const generics clearer The previous diagnostic caused confusion (rust-lang#70790), so this changes the message to be closer to the message for using non-`structural_match` constants in patterns, explicitly mentioning `#[derive(PartialEq, Eq)]`. Fixesrust-lang#70790. r? @estebank
…Mark-Simulacrum
Document unsafety in core::{option, hash}
Helps with rust-lang#66219.
I think that the part that will need reviewing the most is the `hash/sip.rs` file.
r? @LukasKalbertodt (or someone else from the libs team)Tweak `'static` suggestion code Fixrust-lang#71196.
…tebank fix error code in E0751.md reference: rust-lang#71304
…=Mark-Simulacrum Set `--cfg bootstrap` for stage0 rustdoc Resolvesrust-lang#71455. With this patch, running `./x.py doc --stage 0 src/libstd` with a clean `build` dir successfully outputs docs for `core`, `alloc` and `std` in under a minute. This kind of turnaround for viewing small changes to the standard library documentation is quite nice, and I think we should endeavour to keep it working. I'm not sure how involved that would be though. r? @Mark-Simulacrum
…RalfJung Add leading 0x to offset in Debug fmt of Pointer Currently the `Debug` format for `Pointer` prints its offset in hexadecimal, for example, `alloc38657819+e2` or `alloc35122748+64`. This PR adds a leading `0x` to the offset, in order to make it apparent that it is indeed a hexadecimal number. This came up during discussion of rust-lang/miri#1354. r? @RalfJung
Dylan-DPC-zz
commented
Apr 23, 2020
Author
@bors r+ p=6 rollup=never |
bors
commented
Apr 23, 2020
Collaborator
📌 Commit a9da98f has been approved by |
bors
commented
Apr 23, 2020
Collaborator
⌛ Testing commit a9da98f with merge f6f3fd5e2b71803a322096caea2228e95cc7bb45... |
bors
commented
Apr 23, 2020
Collaborator
💔 Test failed - checks-azure |
Dylan-DPC-zz
commented
Apr 23, 2020
Author
looks like it spuriously failed on wasm... :/ @bors retry |
bors
commented
Apr 23, 2020
Collaborator
⌛ Testing commit a9da98f with merge 0e3e6e59d5c336c0c8037a734186b811b58aa4a0... |
bors
commented
Apr 24, 2020
Collaborator
💔 Test failed - checks-azure |
bors
commented
Apr 24, 2020
Collaborator
☔ The latest upstream changes (presumably #71496) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
structural_matcherror diagnostic for const generics clearer #70845 (Make thestructural_matcherror diagnostic for const generics clearer)'staticsuggestion code #71235 (Tweak'staticsuggestion code)--cfg bootstrapfor stage0 rustdoc #71458 (Set--cfg bootstrapfor stage0 rustdoc)Failed merges:
r? @ghost