Uh oh!
There was an error while loading. Please reload this page.
Do not strip leading whitespace when parsing doc comments. - #7174
Closed
SiegeLord wants to merge 1 commit into
Closed
Do not strip leading whitespace when parsing doc comments.#7174SiegeLord wants to merge 1 commit into
SiegeLord wants to merge 1 commit into
Conversation
This change prevents the indentation in code blocks inside the /// doc comments from being eaten. The indentation that is the same across the consecutive doc comments is removed by the uindent_pass in librustdoc.
bors added a commit
that referenced
this pull request
Jun 17, 2013
This change prevents the indentation in code blocks inside the /// doc comments from being eaten. The indentation that is the same across the consecutive doc comments is removed by the uindent_pass in librustdoc. The bug can be seen, e.g., here: http://static.rust-lang.org/doc/std/iterator.html#example-12 I also altered how the block comments are treated, for consistency. There isn't much testing done on the documentation output (I added a few tests of my own for the modified function), so I don't know if anything relied on the previous behavior. I checked a number of documentation files and observed either no change in output or changes that consistent of the above bug being fixed.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
May 6, 2021
Fix eval_order_dependence async false positive changelog: Fix [`eval_order_dependence`] false positive in async code Fixesrust-lang#6925
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7174: Normalize line endings when formatting r=matklad a=Jesse-Bakker Fixesrust-lang#7166 Co-authored-by: Jesse Bakker <github@jessebakker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents the indentation in code blocks inside the /// doc comments
from being eaten. The indentation that is the same across the consecutive doc
comments is removed by the uindent_pass in librustdoc.
The bug can be seen, e.g., here: http://static.rust-lang.org/doc/std/iterator.html#example-12
I also altered how the block comments are treated, for consistency. There isn't much testing done on the documentation output (I added a few tests of my own for the modified function), so I don't know if anything relied on the previous behavior. I checked a number of documentation files and observed either no change in output or changes that consistent of the above bug being fixed.