Uh oh!
There was an error while loading. Please reload this page.
Update RLS - #71875
Conversation
rust-highfive
commented
May 4, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Xanewok
commented
May 4, 2020
@bors r+ |
bors
commented
May 4, 2020
📌 Commit b65594fc0bd238e8557f524ca108df52fd5be69e has been approved by |
Xanewok
commented
May 4, 2020
@bors p=1 since it's fixing toolstate |
bors
commented
May 4, 2020
⌛ Testing commit b65594fc0bd238e8557f524ca108df52fd5be69e with merge 69c873c2184b20057dc973eae53d29e2e60189ff... |
Dylan-DPC-zz
commented
May 4, 2020
@bors retry (yielding priority for the stable release pr ) |
bors
commented
May 5, 2020
⌛ Testing commit b65594fc0bd238e8557f524ca108df52fd5be69e with merge 451ffb1a58d93b0c99e105df2e2231182b97f769... |
bors
commented
May 5, 2020
💔 Test failed - checks-azure |
Xanewok
commented
May 5, 2020
On it |
In addition to fixing the toolstate, this also changes the default compilation model to the out-of-process one, which should hopefully target considerable memory usage for long-running instances of the RLS.
Xanewok
commented
May 5, 2020
r? @Mark-Simulacrum since this also changes some unified features in rustc-workspace-hack |
Mark-Simulacrum
commented
May 5, 2020
Seems fine, thanks! @bors r+ |
bors
commented
May 5, 2020
📌 Commit b512b1c has been approved by |
emilyalbini
commented
May 5, 2020
@bors treeclosed- |
bors
commented
May 5, 2020
⌛ Testing commit b512b1c with merge 7ddbbf1af5e1c93a1bf9c2cf2dae28ae3dd71cd2... |
bors
commented
May 5, 2020
💔 Test failed - checks-actions |
Dylan-DPC-zz
commented
May 5, 2020
spurious? cc @rust-lang/infra |
emilyalbini
commented
May 5, 2020
Nope, this seems legit: |
Xanewok
commented
May 5, 2020
Oh I just pushed this myself locally, thanks @tmandry! |
tmandry
commented
May 5, 2020
hah, I was worried it was outside working hours for you 😄 |
tmandry
commented
May 5, 2020
Let's get this in. @bors r+ p=1 |
bors
commented
May 5, 2020
📌 Commit 3b8358e has been approved by |
bors
commented
May 5, 2020
⌛ Testing commit 3b8358e with merge 9a9ccb19891e727071a450f7cd4735e93d965828... |
Dylan-DPC-zz
commented
May 5, 2020
@bors retry yield |
bors
commented
May 5, 2020
bors
commented
May 6, 2020
☀️ Test successful - checks-actions, checks-azure |
rust-highfive
commented
May 6, 2020
Tested on commit rust-lang/rust@43271a3. Direct link to PR: <rust-lang/rust#71875> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
In addition to fixing the toolstate, this also changes the default
compilation model to the out-of-process one, which should hopefully
target considerable memory usage for long-running instances of the RLS.
Fixes#71753
r? @ghost