Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #71879
Merged
Merged
Conversation
- Documented rationale of current solution - Polished documentation
I believe that this is a copy/paste error; this example was using f32, but it's the docs for f64.
…pnkfelix forbid `dyn Trait` in patterns Do not allow `&dyn Trait` as a generic const parameters. This also changes dyn trait in pattern from ICE to error. closesrust-lang#63322closesrust-lang#70972 r? @eddyb
…wesleywiser Added MIR constant propagation of Scalars into function call arguments Now for the function call arguments! Caveats: 1. It's only being enabled at `mir-opt-2` or higher, because currently codegen gives performance regressions with this optimization. 2. Only propagates Scalars. Tuples and references (references are `Indirect`, right??) are not being propagated into as of this PR. 3. Maybe more tests would be nice? 4. I need (shamefully) to ask @wesleywiser to write in his words (or explain to me, and then I can write it down) why we want to ignore propagation into `ScalarPairs` and `Indirect` arguments. r? @wesleywiser
doc: misc rustdoc things
Do not try to find binop method on RHS `TyErr` Fixrust-lang#71798.
…ark-Simulacrum Use f64 in f64 examples I believe that this is a copy/paste error; this example was using f32, but it's the docs for f64.
Dylan-DPC-zz
commented
May 4, 2020
Author
@bors r+ rollup=never p=5 |
bors
commented
May 4, 2020
Collaborator
📌 Commit fc2837b has been approved by |
bors
commented
May 4, 2020
Collaborator
bors
commented
May 4, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
dyn Traitin patterns #71038 (forbiddyn Traitin patterns)TyErr#71810 (Do not try to find binop method on RHSTyErr)Failed merges:
r? @ghost