Uh oh!
There was an error while loading. Please reload this page.
Sort "implementations on foreign types" section in the sidebar - #71945
Merged
bors merged 1 commit intoMay 10, 2020
Merged
Conversation
kinnison
approved these changes
May 8, 2020
kinnison
left a comment
Contributor
There was a problem hiding this comment.
This appears to do as intended. Is there a need to add a test to ensure things remain sorted? is there anything else whose sort ordering needs tweaking? If the answer to those two points is "no" then I'm okay for this to be merged r=kinnison
ollie27
reviewed
May 9, 2020
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
commented
May 9, 2020
MemberAuthor
GuillaumeGomezforce-pushed
the
sort-impl-on-foreign-types-section
branch
from
May 9, 2020 10:51
caed5e2 to
27f7297CompareGuillaumeGomez
commented
May 9, 2020
MemberAuthor
Updated! |
kinnison
reviewed
May 9, 2020
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomezforce-pushed
the
sort-impl-on-foreign-types-section
branch
from
May 9, 2020 11:50
27f7297 to
b865db0CompareGuillaumeGomez
commented
May 9, 2020
MemberAuthor
Updated! |
ollie27
commented
May 9, 2020
Contributor
@bors r=kinnison,ollie27 |
bors
commented
May 9, 2020
Collaborator
📌 Commit b865db0 has been approved by |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
…-types-section, r=kinnison,ollie27 Sort "implementations on foreign types" section in the sidebar Fixesrust-lang#71926. We were sorting by the ID instead of sorting by the name. They're not in the same order as the implementations but I think it makes more sense this way considering this is what we do for the methods as well. r? @kinnison cc @rust-lang/rustdoc
This was referenced May 10, 2020
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#71840 (Rework MIR drop tree lowering) - rust-lang#71882 (Update the `cc` crate) - rust-lang#71945 (Sort "implementations on foreign types" section in the sidebar) - rust-lang#72043 (Add missing backtick in E0569 explanation) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#71926.
We were sorting by the ID instead of sorting by the name. They're not in the same order as the implementations but I think it makes more sense this way considering this is what we do for the methods as well.
r? @kinnison
cc @rust-lang/rustdoc