Skip to content

Don't add attribute to allow unused-qualifications to derive impl's - #71969

Closed
samrat wants to merge 1 commit into
rust-lang:masterfrom
samrat:unused-qualification-in-derive
Closed

Don't add attribute to allow unused-qualifications to derive impl's#71969
samrat wants to merge 1 commit into
rust-lang:masterfrom
samrat:unused-qualification-in-derive

Conversation

@samrat

@samratsamrat commented May 7, 2020

Copy link
Copy Markdown
Contributor

Currently #![forbid(unused_qualifications)] is incompatible with all derive's because we add #[allow(unused_qualifications)] in all generated impl's.

Closes#71898

@samrat
Don't add attribute to allow unused-qualifications to derive impl's
54a6757
Currently `#![forbid(unused_qualifications)]` is incompatible with all
derive's because we add `#[allow(unused_qualifications)]` in all
generated impl's.
@rust-highfive

rust-highfive commented May 7, 2020

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2020
@cramertj

cramertj commented May 8, 2020

Copy link
Copy Markdown
Member

r? @jonas-schievink

@bors

bors commented May 9, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #72041) made this pull request unmergeable. Please resolve the merge conflicts.

@Muirrum

Muirrum commented Jun 13, 2020

Copy link
Copy Markdown

@rustbot modify labels to +S-waiting-on-author -S-waiting-on-review

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
@jonas-schievink

jonas-schievink commented Jun 13, 2020

Copy link
Copy Markdown
Contributor

r? @varkor

@samrat
samrat marked this pull request as ready for review June 13, 2020 15:03
@varkor

varkor commented Jun 18, 2020

Copy link
Copy Markdown
Contributor

The #[allow(unused_qualifications)] was originally added to fix #19102. Does this issue no longer occur even without it?

@Elinvynia

Elinvynia commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

Ping from triage: @samrat
Hello, it looks like this PR also needs a rebase, could you have a look when you have the time?

@ElinvyniaElinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2020
@Muirrum

Muirrum commented Jul 24, 2020

Copy link
Copy Markdown

Another ping from triage @samrat

@Dylan-DPC-zz

Dylan-DPC-zz commented Jul 24, 2020

Copy link
Copy Markdown

@samrat closing this pr due to inactivity. If you have time again, you can open a new pr with these changes. Thanks for taking the time to contribute :)

@Dylan-DPC-zzDylan-DPC-zz added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@varkorvarkor

Labels

S-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#[forbid(unused_qualifications)] is incompatible with all builtin derives

10 participants

@samrat@rust-highfive@cramertj@bors@Muirrum@jonas-schievink@varkor@Elinvynia@Dylan-DPC-zz@rustbot