Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #71985
Merged
Merged
Conversation
On Windows, these types were causing warnings to be emitted during the build. These types are allowed to not have idiomatic names, so the warning should be supressed.
Use trait_object_dummy_self instead of err r? @eddyb cc rust-lang#70866.
Add some regression tests Closesrust-lang#29988Closesrust-lang#34979 Pick up two snippets that have been fixed from rust-lang#67945 (shouldn't be closed yet!)
…acrum tests: Fix warnings in `rust_test_helpers.c` MSVC is silly and doesn't recognize `assert` as diverging.
Grammar I've split this into individual changes so that people can veto individually. I'm not attached to most of them. `zeroes` vs. `zeros` is why I took the effort to run this through app.grammarly (which disappointingly didn't even notice).
…, r=oli-obk use hex for pointers in Miri error messages Also refine vtable error message: distinguish between "drop fn does not point to a function" and "drop fn points to a function with the wrong signature".
…-Simulacrum Allow a few warnings. On Windows, these types were causing warnings to be emitted during the build. These types are allowed to not have idiomatic names, so the warning should be supressed.
Dylan-DPC-zz
commented
May 7, 2020
Author
@bors r+ rollup=never p=6 |
bors
commented
May 7, 2020
Collaborator
📌 Commit c818e84 has been approved by |
bors
commented
May 7, 2020
Collaborator
bors
commented
May 7, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust_test_helpers.c#71959 (tests: Fix warnings inrust_test_helpers.c)Failed merges:
r? @ghost