Uh oh!
There was an error while loading. Please reload this page.
Incomplete features can also be unsound - #72045
Merged
Merged
Conversation
rust-highfive
commented
May 9, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
May 9, 2020
Contributor
@bors r+ |
bors
commented
May 9, 2020
Collaborator
📌 Commit 6a8cf4a has been approved by |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
May 11, 2020
…ochenkov Incomplete features can also be unsound Some incomplete features do not just ICE, they are also currently unsound (e.g. rust-lang#72029, and also `specialization` -- which is not yet marked incomplete but [should be](rust-lang#71420)). This makes the message reflect that. While at it I also added a link to the tracking issue, which hopefully should explain what is incomplete/unsound about the feature.
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
May 14, 2020
…ochenkov Incomplete features can also be unsound Some incomplete features do not just ICE, they are also currently unsound (e.g. rust-lang#72029, and also `specialization` -- which is not yet marked incomplete but [should be](rust-lang#71420)). This makes the message reflect that. While at it I also added a link to the tracking issue, which hopefully should explain what is incomplete/unsound about the feature.
bors
commented
May 16, 2020
Collaborator
⌛ Testing commit 6a8cf4a with merge 459102af8502f63ad99261bdf72a914108ca674a... |
RalfJung
commented
May 16, 2020
MemberAuthor
Yielding. @bors retry |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72045 (Incomplete features can also be unsound) - rust-lang#72047 (Literal error reporting cleanup) - rust-lang#72060 (move `ty::List` into a new submodule) - rust-lang#72094 (cmdline: Make target features individually overridable) - rust-lang#72254 (Remove redundant backtick in error message.) Failed merges: r? @ghost
bors
commented
May 16, 2020
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some incomplete features do not just ICE, they are also currently unsound (e.g. #72029, and also
specialization-- which is not yet marked incomplete but should be). This makes the message reflect that.While at it I also added a link to the tracking issue, which hopefully should explain what is incomplete/unsound about the feature.