Refactor and adjust non_ascii_idents lints. by crlf0710 · Pull Request #72069 · rust-lang/rust

crlf0710 · 2020-05-10T01:33:16Z

The adjustment is according to rust-lang/rfcs#2923 . This also turned on confusable_idents lint, since the performance impact is resolved by this adjustment.

rust-highfive · 2020-05-10T01:33:20Z

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

crlf0710 · 2020-05-10T01:33:46Z

r? @Manishearth

rust-highfive · 2020-05-10T02:44:30Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 3'
Agent machine name: 'fv-az619'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200430.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200430.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.1)
Checking job knob settings.
Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c9c30c8d-88c2-46b5-bc88-db0d2b6e5225.sh
##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72069/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72069/merge:refs/remotes/pull/72069/merge
---
---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS --build=x86_64-unknown-linux-gnu --llvm-root=/usr/lib/llvm-8 --enable-llvm-link-shared --set rust.thin-lto-import-instr-limit=10
---> Using cache
---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy && python2.7 ../x.py test src/test/mir-opt --pass=build --target=armv5te-unknown-linux-gnueabi && python2.7 ../x.py test src/tools/tidy
---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
---> Using cache
---> 091087e35a36
---
Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
Compiling chalk-rust-ir v0.10.0
Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Compiling chalk-solve v0.10.0
Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
Compiling chalk-rust-ir v0.10.0
Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Compiling chalk-solve v0.10.0
Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
.....................................................i.............................................. 1800/10159
.................................................................................................... 1900/10159
.......................................................................i............................ 2000/10159
.................................................................................................... 2100/10159
.............................................................iiiii.................................. 2200/10159
.................................................................................................... 2400/10159
.................................................................................................... 2500/10159
.................................................................................................... 2600/10159
.................................................................................................... 2700/10159
---
.................................................................................................... 5200/10159
.................................................................................................... 5300/10159
........................i........................................................................... 5400/10159
.................i.................................................................................. 5500/10159
........................ii.ii........i...i.......................................................... 5600/10159
.........................................................................i...............FF......... 5800/10159
.................................................................................................... 5900/10159
....................ii.....................................i........................................ 6000/10159
.................................................................................................... 6100/10159
.................................................................................................... 6100/10159
.................................................................................................... 6200/10159
.................................................................................ii...i..ii......... 6300/10159
.................................................................................................... 6500/10159
.................................................................................................... 6600/10159
.................................................................................................... 6700/10159
.................................................................................................... 6700/10159
..............i..ii................................................................................. 6800/10159
.................................................................................................... 7000/10159
...................................................................i................................ 7100/10159
...........................................................................................F........ 7200/10159
.................................................................................................... 7300/10159
---
.................................................................................................... 8100/10159
.................................................................................................... 8200/10159
..................................................................................i................. 8300/10159
.................................................................................................... 8400/10159
....................................iiiiii.iiiii.i.................................................. 8500/10159
.................................................................................................... 8700/10159
.................................................................................................... 8800/10159
.................................................................................................... 8900/10159
.................................................................................................... 9000/10159
---
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48508/issue-48508.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args issues/issue-48508.rs`
error: 1 errors occurred comparing output.
status: exit code: 0
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-48508.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48508/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-g" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48508/auxiliary"
------------------------------------------
------------------------------------------
stderr:
---
25 error: identifier contains non-ASCII characters
- --> $DIR/lint-non-ascii-idents.rs:10:20
+ --> $DIR/lint-non-ascii-idents.rs:4:7
27 |
- LL | println!("{}", naïveté);
+ LL | const חלודה: usize = 2;
+ | ^^^^^
30 - error: aborting due to 4 previous errors
- error: aborting due to 4 previous errors
+ error: aborting due to 3 previous errors
32 33 The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents/lint-non-ascii-idents.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
error: identifier contains non-ASCII characters
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:6:4
|
LL | fn coöperation() {} //~ ERROR identifier contains non-ASCII characters
|
note: the lint level is defined here
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:2:9
|
|
LL | #![deny(non_ascii_idents)]
| ^^^^^^^^^^^^^^^^
error: identifier contains non-ASCII characters
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:9:9
|
LL | let naïveté = 2; //~ ERROR identifier contains non-ASCII characters
error: identifier contains non-ASCII characters
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:4:7
|
|
LL | const חלודה: usize = 2; //~ ERROR identifier contains non-ASCII characters
error: aborting due to 3 previous errors
---
1 error: identifier contains uncommon Unicode codepoints
- --> $DIR/lint-uncommon-codepoints.rs:4:7
+ --> $DIR/lint-uncommon-codepoints.rs:6:4
3 |
- LL | const µ: f64 = 0.000001;
- | ^
+ LL | fn dĳkstra() {}
6 |
7 note: the lint level is defined here
8 --> $DIR/lint-uncommon-codepoints.rs:2:9
11 | ^^^^^^^^^^^^^^^^^^^
12 13 error: identifier contains uncommon Unicode codepoints
- --> $DIR/lint-uncommon-codepoints.rs:6:4
+ --> $DIR/lint-uncommon-codepoints.rs:4:7
15 |
- LL | fn dĳkstra() {}
- | ^^^^^^^
+ LL | const µ: f64 = 0.000001;
18 19 error: identifier contains uncommon Unicode codepoints
20 --> $DIR/lint-uncommon-codepoints.rs:9:9
22 LL | let ㇻㇲㇳ = "rust";
24 - error: identifier contains uncommon Unicode codepoints
- --> $DIR/lint-uncommon-codepoints.rs:10:20
- |
---
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints/lint-uncommon-codepoints.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
error: identifier contains uncommon Unicode codepoints
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:6:4
|
LL | fn dĳkstra() {} //~ ERROR identifier contains uncommon Unicode codepoints
|
note: the lint level is defined here
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:2:9
|
|
LL | #![deny(uncommon_codepoints)]
| ^^^^^^^^^^^^^^^^^^^
error: identifier contains uncommon Unicode codepoints
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:4:7
|
LL | const µ: f64 = 0.000001; //~ ERROR identifier contains uncommon Unicode codepoints
error: identifier contains uncommon Unicode codepoints
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:9:9
|
|
LL | let ㇻㇲㇳ = "rust"; //~ ERROR identifier contains uncommon Unicode codepoints
error: aborting due to 3 previous errors
---
+ | ^
+ |
+ = note: `#[warn(uncommon_codepoints)]` on by default
+ + error: aborting due to 3 previous errors; 1 warning emitted
34 The actual stderr differed from the expected stderr.
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issue-62524/issue-62524.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args parser/issue-62524.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/issue-62524.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issue-62524" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issue-62524/auxiliary"
------------------------------------------
------------------------------------------
stderr:
---
| |__^
|
help: change the delimiters to curly braces
|
LL | y! { /* items */ }
help: add a semicolon
|
LL | Ϥ,;
| ^
---
| ^
|
= note: `#[warn(uncommon_codepoints)]` on by default
error: aborting due to 3 previous errors; 1 warning emitted
------------------------------------------
---
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 1:05:44
Build completed unsuccessfully in 1:05:44
== clock drift check ==
local time: Sun May 10 02:44:10 UTC 2020
network time: Sun, 10 May 2020 02:44:10 GMT
== end clock drift check ==
##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72069/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
Author : Microsoft
Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72069/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3532) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-05-10T07:00:25Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 48'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200430.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200430.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.1)
Checking job knob settings.
Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/acf3c502-b59d-467b-9dfe-1434c10167fb.sh
##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72069/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72069/merge:refs/remotes/pull/72069/merge
---
---> 3adb0605cc65
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
---> Using cache
---> 28dbc326cb7f
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors && python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu && python3 ../x.py build --stage 0 src/tools/build-manifest && python3 ../x.py test --stage 0 src/tools/compiletest && python3 ../x.py test src/tools/tidy && python3 ../x.py doc --stage 0 src/libstd && /scripts/validate-toolstate.sh
---> 537a01811900
Successfully built 537a01811900
Successfully tagged rust-ci:latest
Built container sha256:537a018119009dc218456238dec90b5530050db1e2a1e166550c218003f6159d
---
Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Checking chalk-rust-ir v0.10.0
Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
configure: dist.missing-tools := True
configure: rust.codegen-units-std := 1
configure: rust.verify-llvm-ir := True
configure: rust.channel := nightly
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: configure: run `python /checkout/x.py --help`
configure: ---
Hugepagesize: 2048 kB
DirectMap4k: 143296 kB
DirectMap2M: 4050944 kB
DirectMap1G: 5242880 kB
+ python3 ../x.py test src/tools/expand-yaml-anchors
Ensuring the YAML anchors in the GitHub Actions config were expanded
Ensuring the YAML anchors in the GitHub Actions config were expanded
Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
Compiling unicode-xid v0.2.0
Compiling syn v1.0.11
Compiling linked-hash-map v0.5.2
Compiling lazy_static v1.4.0
Compiling lazy_static v1.4.0
Compiling yaml-rust v0.4.3
Compiling quote v1.0.2
Compiling thiserror-impl v1.0.5
Compiling thiserror v1.0.5
Compiling yaml-merge-keys v0.4.0
Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
Build completed successfully in 0:00:27
+ python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
Finished dev [unoptimized] target(s) in 0.20s
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Checking chalk-rust-ir v0.10.0
Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
Done!
some tidy checks failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
Build completed unsuccessfully in 0:00:32
Build completed unsuccessfully in 0:00:32
== clock drift check ==
local time: Sun May 10 06:04:30 UTC 2020
network time: Sun, 10 May 2020 06:04:30 GMT
== end clock drift check ==
##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72069/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
Author : Microsoft
Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72069/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3770) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-05-10T09:06:46Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 2'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200430.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200430.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.1)
Checking job knob settings.
Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/ce808d3f-2675-4f32-8f04-e83f982e6cf3.sh
##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72069/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72069/merge:refs/remotes/pull/72069/merge
---
---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS --build=x86_64-unknown-linux-gnu --llvm-root=/usr/lib/llvm-8 --enable-llvm-link-shared --set rust.thin-lto-import-instr-limit=10
---> Using cache
---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy && python2.7 ../x.py test src/test/mir-opt --pass=build --target=armv5te-unknown-linux-gnueabi && python2.7 ../x.py test src/tools/tidy
---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
---> Using cache
---> 091087e35a36
---
Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Compiling chalk-rust-ir v0.10.0
Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Compiling chalk-solve v0.10.0
Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
Compiling chalk-rust-ir v0.10.0
Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Compiling chalk-solve v0.10.0
Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
.....................................................i.............................................. 1800/10160
.................................................................................................... 1900/10160
.......................................................................i............................ 2000/10160
.................................................................................................... 2100/10160
.............................................................iiiii.................................. 2200/10160
.................................................................................................... 2400/10160
.................................................................................................... 2500/10160
.................................................................................................... 2600/10160
.................................................................................................... 2700/10160
---
.................................................................................................... 5200/10160
.................................................................................................... 5300/10160
........................i........................................................................... 5400/10160
.................i.................................................................................. 5500/10160
........................ii.ii........i...i.......................................................... 5600/10160
.........................................................................i...............FF......... 5800/10160
.................................................................................................... 5900/10160
....................ii.....................................i........................................ 6000/10160
.................................................................................................... 6100/10160
.................................................................................................... 6100/10160
.................................................................................................... 6200/10160
.................................................................................ii...i..ii......... 6300/10160
.................................................................................................... 6500/10160
.................................................................................................... 6600/10160
.................................................................................................... 6700/10160
.................................................................................................... 6700/10160
..............i..ii................................................................................. 6800/10160
.................................................................................................... 7000/10160
....................................................................i............................... 7100/10160
.................................................................................................... 7200/10160
.................................................................................................... 7300/10160
---
.................................................................................................... 8100/10160
.................................................................................................... 8200/10160
...................................................................................i................ 8300/10160
.................................................................................................... 8400/10160
.....................................iiiiii.iiiii.i................................................. 8500/10160
.................................................................................................... 8700/10160
.................................................................................................... 8800/10160
.................................................................................................... 8900/10160
.................................................................................................... 9000/10160
---
1 error: identifier contains non-ASCII characters
- --> $DIR/lint-non-ascii-idents.rs:9:9
+ --> $DIR/lint-non-ascii-idents.rs:6:4
3 |
- LL | let naïveté = 2;
+ LL | fn coöperation() {}
+ | ^^^^^^^^^^^
6 |
7 note: the lint level is defined here
---
+ --> $DIR/lint-non-ascii-idents.rs:9:9
15 |
- LL | const חלודה: usize = 2;
- | ^^^^^
+ LL | let naïveté = 2;
18 19 error: identifier contains non-ASCII characters
- --> $DIR/lint-non-ascii-idents.rs:6:4
+ --> $DIR/lint-non-ascii-idents.rs:4:7
---
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents/lint-non-ascii-idents.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
error: identifier contains non-ASCII characters
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:6:4
|
LL | fn coöperation() {} //~ ERROR identifier contains non-ASCII characters
|
note: the lint level is defined here
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:2:9
|
|
LL | #![deny(non_ascii_idents)]
| ^^^^^^^^^^^^^^^^
error: identifier contains non-ASCII characters
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:9:9
|
LL | let naïveté = 2; //~ ERROR identifier contains non-ASCII characters
error: identifier contains non-ASCII characters
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-non-ascii-idents.rs:4:7
|
|
LL | const חלודה: usize = 2; //~ ERROR identifier contains non-ASCII characters
error: aborting due to 3 previous errors
---
12 13 error: identifier contains uncommon Unicode codepoints
- --> $DIR/lint-uncommon-codepoints.rs:9:9
- |
- LL | let ㇻㇲㇳ = "rust";
- - error: identifier contains uncommon Unicode codepoints
20 --> $DIR/lint-uncommon-codepoints.rs:4:7
21 |
21 |
22 LL | const µ: f64 = 0.000001;
23 | ^
+ + error: identifier contains uncommon Unicode codepoints
+ --> $DIR/lint-uncommon-codepoints.rs:9:9
+ --> $DIR/lint-uncommon-codepoints.rs:9:9
+ |
+ LL | let ㇻㇲㇳ = "rust";
24 25 error: aborting due to 3 previous errors
26 The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints/lint-uncommon-codepoints.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
error: identifier contains uncommon Unicode codepoints
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:6:4
|
LL | fn dĳkstra() {} //~ ERROR identifier contains uncommon Unicode codepoints
|
note: the lint level is defined here
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:2:9
|
|
LL | #![deny(uncommon_codepoints)]
| ^^^^^^^^^^^^^^^^^^^
error: identifier contains uncommon Unicode codepoints
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:4:7
|
LL | const µ: f64 = 0.000001; //~ ERROR identifier contains uncommon Unicode codepoints
error: identifier contains uncommon Unicode codepoints
--> /checkout/src/test/ui/lint/rfc-2457-non-ascii-idents/lint-uncommon-codepoints.rs:9:9
|
|
LL | let ㇻㇲㇳ = "rust"; //~ ERROR identifier contains uncommon Unicode codepoints
error: aborting due to 3 previous errors
---
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 1:01:48
Build completed unsuccessfully in 1:01:48
== clock drift check ==
local time: Sun May 10 09:06:39 UTC 2020
network time: Sun, 10 May 2020 09:06:40 GMT
== end clock drift check ==
##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72069/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
Author : Microsoft
Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72069/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (4363) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

crlf0710 · 2020-05-10T09:34:53Z

It seems FxHashMap is giving machine-dependent order... I'll use BTreeMap for stable ordering.

crlf0710 · 2020-05-12T17:39:54Z

Is this ready to be r+-ed? Also cc @petrochenkov and @Mark-Simulacrum in case they want to have another look. The TL;DR is that since we can skip pure-ascii codebases now, this should no longer have compilation performance regression any more(other than a FxHashMap -> BTreeMap switch), and now i've turned on confusable_idents lint to warn-by-default.

Mark-Simulacrum · 2020-05-12T17:56:29Z

@bors try @rust-timer queue

I want to just check that we're correct that this is not a performance regression. I've not reviewed the code in any detail.

rust-timer · 2020-05-12T17:56:31Z

Awaiting bors try build completion

bors · 2020-05-12T17:56:41Z

⌛ Trying commit 1dd5779cd561d16782839c1b2ae98b08a6f953de with merge 54ca6faced00c0770b52ac83b46739e6b848975b...

bors · 2020-05-12T20:37:50Z

💔 Test failed - checks-actions

crlf0710 · 2020-05-13T01:47:10Z

Mmm, the try bot seems unable to checkout the source code. What does this mean... cc @Mark-Simulacrum

Mark-Simulacrum · 2020-05-13T14:50:41Z

Hm seems spurious, let's @bors retry

bors · 2020-05-13T14:50:55Z

⌛ Trying commit 1dd5779cd561d16782839c1b2ae98b08a6f953de with merge aac49fd2f8e21d595802bc204841ec02b0505f7e...

bors · 2020-05-13T17:58:30Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: aac49fd2f8e21d595802bc204841ec02b0505f7e (aac49fd2f8e21d595802bc204841ec02b0505f7e)

rust-timer · 2020-05-13T17:58:32Z

Queued aac49fd2f8e21d595802bc204841ec02b0505f7e with parent 750db09, future comparison URL.

rust-timer · 2020-05-13T20:27:58Z

Finished benchmarking try commit aac49fd2f8e21d595802bc204841ec02b0505f7e, comparison URL.

crlf0710 · 2020-05-15T08:41:50Z

Seems good enough to me. However some more modifications to rust-lang/rfcs#2923 modification PR is being discussed, i think let's wait a bit.

Manishearth · 2020-05-15T13:27:38Z

Fwiw I don't think we need to immediately update the RFC. The RFC typically doesn't even need to be updated in cases like this.

Manishearth · 2020-05-15T14:26:46Z

Oh, I see what you mean

…ents lint.

@Manishearth

…=Manishearth Implement mixed script confusable lint. This implements the mixed script confusable lint defined in RFC 2457. This is blocked on rust-lang#72069 and unicode-rs/unicode-security#13, and will need a Cargo.toml version bump after those are resolved. The lint message warning is sub-optimal for now. We'll need a mechanism to properly output `AugmentScriptSet` to screen, this is to be added in `unicode-security` crate. r? @Manishearth

@Manishearth

…=Manishearth Implement mixed script confusable lint. This implements the mixed script confusable lint defined in RFC 2457. This is blocked on rust-lang#72069 and unicode-rs/unicode-security#13, and will need a Cargo.toml version bump after those are resolved. The lint message warning is sub-optimal for now. We'll need a mechanism to properly output `AugmentScriptSet` to screen, this is to be added in `unicode-security` crate. r? @Manishearth

@Manishearth

…=Manishearth Implement mixed script confusable lint. This implements the mixed script confusable lint defined in RFC 2457. This is blocked on rust-lang#72069 and unicode-rs/unicode-security#13, and will need a Cargo.toml version bump after those are resolved. The lint message warning is sub-optimal for now. We'll need a mechanism to properly output `AugmentScriptSet` to screen, this is to be added in `unicode-security` crate. r? @Manishearth

rust-highfive assigned ecstatic-morse May 10, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2020

rust-highfive assigned Manishearth and unassigned ecstatic-morse May 10, 2020

crlf0710 force-pushed the confusable_idents branch from 634b66b to 649a579Compare May 10, 2020 05:44

crlf0710 force-pushed the confusable_idents branch from 649a579 to 98c4109Compare May 10, 2020 07:58

crlf0710 force-pushed the confusable_idents branch from 98c4109 to ae4c778Compare May 10, 2020 10:29

crlf0710 changed the title ~~Refactor and just non_ascii_idents lints.~~Refactor and adjust non_ascii_idents lints.May 10, 2020

crlf0710 force-pushed the confusable_idents branch from ae4c778 to 1dd5779Compare May 10, 2020 10:55

crlf0710 mentioned this pull request May 10, 2020
Do not warn about similar ASCII-only idents rust-lang/rfcs#2923
Closed

crlf0710 requested a review from Manishearth May 11, 2020 01:05

Manishearth approved these changes May 11, 2020
View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2020

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2020

crlf0710 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2020

crlf0710 mentioned this pull request May 30, 2020
Implement mixed script confusable lint. #72770
Merged

Refactor non_ascii_idents lints, exclude ascii pair for confusable_id…
ef24faf
…ents lint.

crlf0710 force-pushed the confusable_idents branch from 1dd5779 to ef24fafCompare June 22, 2020 16:08

bors merged commit ef24faf into rust-lang:masterJun 26, 2020

crlf0710 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 26, 2020

Uh oh!

Uh oh!

Conversation

crlf0710 commented May 10, 2020

Uh oh!

rust-highfive commented May 10, 2020

Uh oh!

crlf0710 commented May 10, 2020

Uh oh!

rust-highfive commented May 10, 2020

Uh oh!

rust-highfive commented May 10, 2020

Uh oh!

rust-highfive commented May 10, 2020

Uh oh!

crlf0710 commented May 10, 2020

Uh oh!

crlf0710 commented May 12, 2020

Uh oh!

Mark-Simulacrum commented May 12, 2020

Uh oh!

rust-timer commented May 12, 2020

Uh oh!

bors commented May 12, 2020

Uh oh!

bors commented May 12, 2020

Uh oh!

crlf0710 commented May 13, 2020

Uh oh!

Mark-Simulacrum commented May 13, 2020

Uh oh!

bors commented May 13, 2020

Uh oh!

bors commented May 13, 2020

Uh oh!

rust-timer commented May 13, 2020

Uh oh!

rust-timer commented May 13, 2020

Uh oh!

crlf0710 commented May 15, 2020

Uh oh!

Manishearth commented May 15, 2020

Uh oh!

Manishearth commented May 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants