Skip to content

Propagate locals, even if they have unpropagatable assignments somewhere - #72135

Merged
bors merged 4 commits into
rust-lang:masterfrom
oli-obk:const_prop_deaggregates
May 17, 2020
Merged

Propagate locals, even if they have unpropagatable assignments somewhere#72135
bors merged 4 commits into
rust-lang:masterfrom
oli-obk:const_prop_deaggregates

Conversation

@oli-obk

@oli-obkoli-obk commented May 12, 2020

Copy link
Copy Markdown
Contributor

Second try for #71946 (comment)

r? @wesleywiser

cc @rust-lang/wg-mir-opt @RalfJung

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2020
@wesleywiser

wesleywiser commented May 12, 2020

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

rust-timer commented May 12, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented May 12, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 0a785cd with merge b75ab6aef59abf16a83fbec1804dce3a74244824...

wesleywiser
wesleywiser approved these changes May 12, 2020
View reviewed changes
Comment threadsrc/test/mir-opt/const_prop/mutable_variable_aggregate_partial_read/rustc.main.ConstProp.diff Outdated
// mir::Constant
// + span: $DIR/mutable_variable_aggregate_partial_read.rs:6:11: 6:13
- // + span: $DIR/mutable_variable_aggregate_partial_read.rs:6:11: 6:13
+ // + span: $DIR/mutable_variable_aggregate_partial_read.rs:6:5: 6:13

@wesleywiserwesleywiserMay 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should pull 060e437b776e238a492372fbb278fdc27fef1128 out of #71911 and get that merged so we can eliminate this kind of noise from the const prop tests.

wesleywiser
wesleywiser reviewed May 12, 2020
View reviewed changes
Comment threadsrc/librustc_mir/transform/const_prop.rs
// implement.
trace!(
"propagation into {:?} failed.
Nuking the entire site from orbit, it's the only way to be sure",

@wesleywiserwesleywiserMay 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@bors

bors commented May 12, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: b75ab6aef59abf16a83fbec1804dce3a74244824 (b75ab6aef59abf16a83fbec1804dce3a74244824)

@rust-timer

rust-timer commented May 12, 2020

Copy link
Copy Markdown
Collaborator

Queued b75ab6aef59abf16a83fbec1804dce3a74244824 with parent d903a9d, future comparison URL.

@rust-timer

rust-timer commented May 12, 2020

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit b75ab6aef59abf16a83fbec1804dce3a74244824, comparison URL.

@wesleywiser

wesleywiser commented May 13, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 0a785cd has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2020
@bors

bors commented May 16, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0a785cd with merge edfb262856755d7532ca4cb452d5668360e68f9b...

@bors

bors commented May 16, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2020
@wesleywiser

wesleywiser commented May 17, 2020

Copy link
Copy Markdown
Member

@oli-obk I took the liberty of pushing a commit to your branch which blesses the new tests again since #72220 landed.

r=me if you're ok with that 🙂

@RalfJung

RalfJung commented May 17, 2020

Copy link
Copy Markdown
Member

LGTM. @bors r=wesleywiser

@bors

bors commented May 17, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 27c818b has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2020
@bors

bors commented May 17, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 27c818b with merge 7faeae0...

@bors

bors commented May 17, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: wesleywiser
Pushing 7faeae0 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2020
@bors
bors merged commit 7faeae0 into rust-lang:masterMay 17, 2020
@oli-obk
oli-obk deleted the const_prop_deaggregates branch May 18, 2020 17:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@wesleywiserwesleywiser

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk@wesleywiser@rust-timer@bors@RalfJung@rust-highfive