Uh oh!
There was an error while loading. Please reload this page.
remove extra space from crate-level doctest names - #72180
Merged
Conversation
Dylan-DPC-zz
commented
May 15, 2020
@bors r+ rollup |
bors
commented
May 15, 2020
Collaborator
📌 Commit ce915f5 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
…Dylan-DPC remove extra space from crate-level doctest names Before: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ``` After: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ```
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
…Dylan-DPC remove extra space from crate-level doctest names Before: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ``` After: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ```
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
…Dylan-DPC remove extra space from crate-level doctest names Before: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ``` After: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ```
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
…Dylan-DPC remove extra space from crate-level doctest names Before: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ``` After: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ```
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
…Dylan-DPC remove extra space from crate-level doctest names Before: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ``` After: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ```
Dylan-DPC-zz
commented
May 16, 2020
euclio
commented
May 16, 2020
ContributorAuthor
Looks like the test order is nondeterministic. |
euclioforce-pushed
the
rustdoc-test-extra-space
branch
from
May 16, 2020 03:56
ce915f5 to
c379fb5Compareeuclio
commented
May 16, 2020
ContributorAuthor
Should be ready for another run. Limited the number of test threads to 1. |
euclio
commented
May 24, 2020
ContributorAuthor
Ping @Dylan-DPC |
Dylan-DPC-zz
commented
Jun 3, 2020
@euclio sorry i missed this one. do you want me to try it? |
euclio
commented
Jun 3, 2020
ContributorAuthor
Please do, thanks! |
Dylan-DPC-zz
commented
Jun 4, 2020
@bors try |
bors
commented
Jun 4, 2020
Collaborator
⌛ Trying commit c379fb5 with merge 3dab4208535a5260626b715a5674248af35c94b9... |
bors
commented
Jun 4, 2020
Collaborator
☀️ Try build successful - checks-azure |
steveklabnik
commented
Jun 8, 2020
Contributor
@bors: r? @Dylan-DPC |
Dylan-DPC-zz
commented
Jun 11, 2020
@bors r+ |
bors
commented
Jun 11, 2020
Collaborator
📌 Commit c379fb5 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 11, 2020
…Dylan-DPC remove extra space from crate-level doctest names Before: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ``` After: ``` running 2 tests test src/test/rustdoc-ui/doctest-output.rs - foo::bar (line 11) ... ok test src/test/rustdoc-ui/doctest-output.rs - (line 5) ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ```
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#72180 (remove extra space from crate-level doctest names) - rust-lang#73012 (Show `SyntaxContext` in formatted `Span` debug output) - rust-lang#73097 (Try_run must only be used if toolstate is populated) - rust-lang#73169 (Handle assembler warnings properly) - rust-lang#73182 (Track span of function in method calls, and use this in #[track_caller]) - rust-lang#73207 (Clean up E0648 explanation) - rust-lang#73230 (Suggest including unused asm arguments in a comment to avoid error) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: