Skip to content

Cleanup stale 'FIXME(#64197)' - #72206

Merged
bors merged 1 commit into
rust-lang:masterfrom
sergey-melnychuk:cleanup-stale-fixme
May 16, 2020
Merged

Cleanup stale 'FIXME(#64197)'#72206
bors merged 1 commit into
rust-lang:masterfrom
sergey-melnychuk:cleanup-stale-fixme

Conversation

@sergey-melnychuk

@sergey-melnychuksergey-melnychuk commented May 14, 2020

Copy link
Copy Markdown
Contributor

(My first PR in rust-lang, any feedback is welcome. Please don't hesitate to let me know if I'm trying to do something pointless!)

Trivial cleanup of a stale FIXME, StringReader.pos is no longer exposed. For testing added pos() method that returns cloned value of pos.

@rust-highfive

rust-highfive commented May 14, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2020
@varkor

varkor commented May 15, 2020

Copy link
Copy Markdown
Contributor

I don't have the context for this FIXME, e.g. what the desired fix was. r? @petrochenkov

@petrochenkov

petrochenkov commented May 15, 2020

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 0dc74dc has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request May 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2020
@bors
Auto merge ofrust-lang#72251- Dylan-DPC:rollup-4mik3o7, r=Dylan-DPC
163445a
Rollup of 9 pull requests
Successful merges:
- rust-lang#71662 (Implement FromStr for OsString)
- rust-lang#71677 (Add explicit references to the BuildHasher trait)
- rust-lang#71724 (Doc alias improvements)
- rust-lang#71948 (Suggest to await future before ? operator)
- rust-lang#72090 (rustc_driver: factor out computing the exit code)
- rust-lang#72206 (Cleanup stale 'FIXME(rust-lang#64197)')
- rust-lang#72218 (make sure even unleashed miri does not do pointer stuff)
- rust-lang#72220 ([const-prop] Don't replace Rvalues that are already constants)
- rust-lang#72224 (doc: add links to rotate_(left|right))
Failed merges:
r? @ghost
@bors
bors merged commit c1d5640 into rust-lang:masterMay 16, 2020
@sergey-melnychuk
sergey-melnychuk deleted the cleanup-stale-fixme branch May 16, 2020 16:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergey-melnychuk@rust-highfive@varkor@petrochenkov@bors