Skip to content

Account for trailing comma when suggesting where clauses - #72715

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:trailing-comma-where
May 31, 2020
Merged

Account for trailing comma when suggesting where clauses#72715
bors merged 2 commits into
rust-lang:masterfrom
estebank:trailing-comma-where

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#72693.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2020
@petrochenkov

Copy link
Copy Markdown
Contributor

Nice, one instance of BytePos arithmetic fewer.
@bors r+

@bors

bors commented May 29, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 0fea70673d166a88a9453535a64595c9d087130e has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2020
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r-
r=me with the unused variable causing CI error fixed

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2020
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2020
@rust-highfive

This comment has been minimized.

@estebank
estebankforce-pushed the trailing-comma-where branch from 0fea706 to 0d18136CompareMay 29, 2020 17:12
@estebank

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov

@bors

bors commented May 29, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 0d18136 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request May 31, 2020
…trochenkov
Account for trailing comma when suggesting `where` clauses
Fixrust-lang#72693.
@RalfJungRalfJung mentioned this pull request May 31, 2020
@RalfJungRalfJung mentioned this pull request May 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2020
Rollup of 5 pull requests
Successful merges:
- rust-lang#72683 (from_u32_unchecked: check validity, and fix UB in Wtf8)
- rust-lang#72715 (Account for trailing comma when suggesting `where` clauses)
- rust-lang#72745 (generalize Borrow<[T]> for Interned<'tcx, List<T>>)
- rust-lang#72749 (Update stdarch submodule to latest head)
- rust-lang#72781 (Use `LocalDefId` instead of `NodeId` in `resolve_str_path_error`)
Failed merges:
r? @ghost
@bors
bors merged commit b714f5c into rust-lang:masterMay 31, 2020
@estebank
estebank deleted the trailing-comma-where branch November 9, 2023 05:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extraneous comma in trait bound suggestion

4 participants

@estebank@rust-highfive@petrochenkov@bors