Uh oh!
There was an error while loading. Please reload this page.
Remove remaining calls to as_local_node_id - #72750
Merged
Merged
Conversation
rust-highfive
commented
May 29, 2020
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
marmeladema
commented
May 29, 2020
ContributorAuthor
marmeladema
commented
May 29, 2020
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
May 29, 2020
Contributor
Same comments from #72552 apply. |
ContributorAuthor
I've addressed the one comment I could, as I explained, I don't think I can use Especially here: https://github.com/marmeladema/rust/blob/remove-as-local-node-id/src/librustc_resolve/build_reduced_graph.rs#L897-L903 the call to |
marmelademaforce-pushed
the
remove-as-local-node-id
branch
from
May 29, 2020 19:06
55c776a to
2f3dd7bComparemarmeladema
commented
May 29, 2020
ContributorAuthor
Ok, based on #72552 (comment) i've updated |
petrochenkov
commented
May 29, 2020
Contributor
@bors r+ |
bors
commented
May 29, 2020
Collaborator
📌 Commit 2f3dd7b has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#72033 (Update RELEASES.md for 1.44.0) - rust-lang#72162 (Add Extend::{extend_one,extend_reserve}) - rust-lang#72419 (Miri read_discriminant: return a scalar instead of raw underlying bytes) - rust-lang#72621 (Don't bail out of trait selection when predicate references an error) - rust-lang#72677 (Fix diagnostics for `@ ..` binding pattern in tuples and tuple structs) - rust-lang#72710 (Add test to make sure -Wunused-crate-dependencies works with tests) - rust-lang#72724 (Revert recursive `TokenKind::Interpolated` expansion for now) - rust-lang#72741 (Remove unused mut from long-linker-command-lines test) - rust-lang#72750 (Remove remaining calls to `as_local_node_id`) - rust-lang#72752 (remove mk_bool) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #72552
cc #50928