Skip to content

Update cargo - #72901

Merged
bors merged 2 commits into
rust-lang:masterfrom
ehuss:update-cargo
Jun 5, 2020
Merged

Update cargo#72901
bors merged 2 commits into
rust-lang:masterfrom
ehuss:update-cargo

Conversation

@ehuss

@ehussehuss commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

9 commits in 9fcb8c1d20c17f51054f7aa4e08ff28d381fe096..40ebd52206e25c7a576ee42c137cc06a745a167a
2020-05-25 16:25:36 +0000 to 2020-06-01 22:35:00 +0000

@ehussehuss self-assigned this Jun 2, 2020
@rust-highfive

rust-highfive commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2020
@ehuss

ehuss commented Jun 2, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors r+

@bors

bors commented Jun 2, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 860b381 has been approved by ehuss

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Jun 3, 2020

Copy link
Copy Markdown

@bors p=1

@bors

bors commented Jun 4, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 860b381 with merge 485518d1222161b0a0ef0bb47c2c028368b07d6d...

@bors

bors commented Jun 4, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2020
@ehuss

ehuss commented Jun 4, 2020

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum do you have any objection if I enable building lld on the Windows job that tests Cargo? Cargo now has a test for some lld behavior on Windows.

AFAIK, lld builds pretty fast (about 40s on my machine) and with sccache should be even faster. I also believe it is not actually used for anything (unless use-lld is enabled, which I believe it isn't).

r? @Mark-Simulacrum

@Mark-Simulacrum

Mark-Simulacrum commented Jun 4, 2020

Copy link
Copy Markdown
Member

Should be fine. @bors r+

@bors

bors commented Jun 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e658200 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2020
@bors

bors commented Jun 4, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e658200 with merge 219380d...

@bors

bors commented Jun 5, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 219380d to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2020
@bors
bors merged commit 219380d into rust-lang:masterJun 5, 2020
@ehussehuss mentioned this pull request Jun 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2020
@bors
Auto merge ofrust-lang#73326- Mark-Simulacrum:beta-next, r=ecstatic…
1dc0f6d
…-morse,Mark-Simulacrum
[beta] backport
This is a beta backport rollup of the following:
* [beta] Revert heterogeneous SocketAddr PartialEq impls rust-lang#73318
* Fix emcc failure for wasm32. rust-lang#73213
* Revert rust-lang#71956rust-lang#73153
* [beta] Update cargo rust-lang#73141
* Minor: off-by-one error in RELEASES.md rust-lang#72914
* normalize adt fields during structural match checking rust-lang#72897
* Revert pr 71840 rust-lang#72989
* rust-lang/cargo#8361
* e658200 from rust-lang#72901
r? @ghost
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If rev is added to git url cargo gives no warnings and has unexpected behavior

5 participants

@ehuss@rust-highfive@bors@Dylan-DPC-zz@Mark-Simulacrum