Uh oh!
There was an error while loading. Please reload this page.
Stabilize std::io::Buf{Reader, Writer}::capacity - #72924
Merged
Merged
Conversation
rust-highfive
commented
Jun 2, 2020
Contributor
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
JohnTitor
commented
Jun 2, 2020
| /// } | ||
| /// ``` | ||
| #[unstable(feature = "buffered_io_capacity", issue = "68833")] | ||
| #[stable(feature = "buffered_io_capacity", since = "1.46.0")] |
MemberAuthor
There was a problem hiding this comment.
I set 1.46.0 here since promoting will happen soon.
Lucretiel
commented
Jun 2, 2020
Contributor
Not a blocker, but related: #72919 |
shepmaster
commented
Jun 2, 2020
Member
|
jonas-schievink
commented
Jun 2, 2020
Contributor
Milestones don't have to be accurate right away, but they need to be set so the release team can update them when a new Rust version is released. |
shepmaster
commented
Jun 3, 2020
Member
Based on the FCP... @bors r+ rollup |
bors
commented
Jun 3, 2020
Collaborator
📌 Commit 7d27c63 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72586 (split select into submodules) - rust-lang#72900 (Don't count pathless --extern for unused-crate-dependencies warnings) - rust-lang#72924 (Stabilize `std::io::Buf{Reader, Writer}::capacity`) - rust-lang#72942 (clean up E0641 explanation) - rust-lang#72945 (Updated documentation for Control Flow Guard) Failed merges: r? @ghost
JohnTitor
commented
Jun 30, 2020
MemberAuthor
Updated the milestone following the stabilize version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#68833
FCP is done here: #68833 (comment)