Fix codegen tests for RISC-V by tblah · Pull Request #72977 · rust-lang/rust

tblah · 2020-06-04T11:28:51Z

Some codegen tests didn't seem relevant (e.g. unsupported annotations).

The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1)

I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

LLVM 10 includes a009a60 which will print value numbers for unnamed func args. Update these tests to be in line with the referenced clang tests.

It isn't clear to me if this is a bug or not, hence the FIXME

rust-highfive · 2020-06-04T11:28:54Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

nikomatsakis · 2020-06-04T22:31:11Z

@bors r+ rollup

bors · 2020-06-04T22:31:13Z

📌 Commit 08529af has been approved by nikomatsakis

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

Dylan-DPC-zz · 2020-06-05T09:31:44Z

failed in rollup log

@bors r-

mati865 · 2020-06-05T10:41:45Z

@Dylan-DPC #72952 caused the failure, not this PR.

Dylan-DPC-zz · 2020-06-05T11:01:40Z

my bad then

@bors r=nikomatsakis

bors · 2020-06-05T11:01:41Z

📌 Commit 08529af has been approved by nikomatsakis

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

@msizanoen1

…atsakis Fix codegen tests for RISC-V Some codegen tests didn't seem relevant (e.g. unsupported annotations). The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1) I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.

RalfJung · 2020-06-06T20:04:41Z

This is one of only a few PRs that are in the intersection of 4 rollups that all failed the same way: #72952, #72977, #73007.

The failure is on 32bit Windows, a bunch of tests show

------------------------------------------
stderr:
------------------------------------------
thread 'rustc' panicked at 'assertion failed: self.ptr <= self.end', D:\a\1\s\src\libstd\macros.rs:13:23
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The line number is utterly useless, it points to the macro definition (how is that possible?!?).

Affected tests:

failures:
[ui] ui\fn\expr-fn-panic.rs
[ui] ui\imports\glob-use-std.rs
[ui] ui\macros\die-macro-2.rs
[ui] ui\macros\die-macro-pure.rs
[ui] ui\macros\unimplemented-macro-panic.rs
[ui] ui\macros\unreachable-macro-panic.rs
[ui] ui\macros\unreachable.rs
[ui] ui\meta-revision-ok.rs#bar
[ui] ui\meta-revision-ok.rs#foo
[ui] ui\mir\mir_codegen_calls_diverging.rs
[ui] ui\panics\doublepanic.rs
[ui] ui\panics\explicit-panic.rs
[ui] ui\panics\main-panic.rs
[ui] ui\panics\panic-macro-explicit.rs
[ui] ui\panics\panic-macro-owned.rs
[ui] ui\panics\panic-macro-static.rs
[ui] ui\panics\panic-main.rs
[ui] ui\rfc-1937-termination-trait\termination-trait-for-never.rs

All 3 PRs in the intersection seem impossible to be the cause here, so I'd appreciate help with figuring out what is going on.^^

Dylan-DPC-zz · 2020-06-07T16:10:54Z

@bors rollup=maybe

@ghost

Rollup of 2 pull requests Successful merges: - rust-lang#72952 (run-make regression test for issue rust-lang#70924.) - rust-lang#72977 (Fix codegen tests for RISC-V) Failed merges: r? @ghost

tblah added 4 commits June 4, 2020 12:02

test: codegen: skip tests inappropriate for riscv64
95e9768

test: codegen: riscv64-abi: print value numbers for unnamed func args
c872dcf
LLVM 10 includes a009a60 which will print value numbers for unnamed func args. Update these tests to be in line with the referenced clang tests.

test: codegen: Add riscv abi llvm intrinsics test
37e8e05

test: codegen: skip catch-unwind on riscv64
08529af
It isn't clear to me if this is a bug or not, hence the FIXME

rust-highfive assigned nikomatsakis Jun 4, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2020

jonas-schievink added the O-riscv Target: RISC-V architecture label Jun 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2020

Dylan-DPC-zz mentioned this pull request Jun 5, 2020
Rollup of 5 pull requests #73009
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2020

Dylan-DPC-zz mentioned this pull request Jun 5, 2020
Rollup of 5 pull requests #73042
Closed

Dylan-DPC-zz mentioned this pull request Jun 5, 2020
Rollup of 5 pull requests #73043
Closed

Dylan-DPC-zz mentioned this pull request Jun 6, 2020
Rollup of 5 pull requests #73048
Closed

Dylan-DPC-zz mentioned this pull request Jun 6, 2020
Rollup of 5 pull requests #73049
Closed

RalfJung mentioned this pull request Jun 6, 2020
Rollup of 7 pull requests #73052
Closed

RalfJung mentioned this pull request Jun 6, 2020
Rollup of 7 pull requests #73053
Closed

RalfJung mentioned this pull request Jun 6, 2020
Rollup of 9 pull requests #73064
Closed

RalfJung mentioned this pull request Jun 6, 2020
impl ToSocketAddrs for (String, u16) #73007
Merged

RalfJung mentioned this pull request Jun 6, 2020
run-make regression test for issue #70924. #72952
Merged

Dylan-DPC-zz mentioned this pull request Jun 7, 2020
Rollup of 2 pull requests #73099
Merged

bors merged commit 4dd5d5d into rust-lang:masterJun 7, 2020

Navigation Menu

Uh oh!

Uh oh!

Fix codegen tests for RISC-V - #72977

Fix codegen tests for RISC-V#72977
bors merged 4 commits into
rust-lang:masterfrom
tblah:riscv-codegen-llvm10

tblah commented Jun 4, 2020

Uh oh!

rust-highfive commented Jun 4, 2020

Uh oh!

nikomatsakis commented Jun 4, 2020

Uh oh!

bors commented Jun 4, 2020

Uh oh!

Dylan-DPC-zz commented Jun 5, 2020

Uh oh!

mati865 commented Jun 5, 2020

Uh oh!

Dylan-DPC-zz commented Jun 5, 2020

Uh oh!

bors commented Jun 5, 2020

Uh oh!

RalfJung commented Jun 6, 2020

Uh oh!

Dylan-DPC-zz commented Jun 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

tblah commented Jun 4, 2020

Uh oh!

rust-highfive commented Jun 4, 2020

Uh oh!

nikomatsakis commented Jun 4, 2020

Uh oh!

bors commented Jun 4, 2020

Uh oh!

Dylan-DPC-zz commented Jun 5, 2020

Uh oh!

mati865 commented Jun 5, 2020

Uh oh!

Dylan-DPC-zz commented Jun 5, 2020

Uh oh!

bors commented Jun 5, 2020

Uh oh!

RalfJung commented Jun 6, 2020

Uh oh!

Dylan-DPC-zz commented Jun 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants