Skip to content

Remove Spans from HIR -- 2/N -- Small HIR nodes - #73094

Closed
cjgillot wants to merge 31 commits into
rust-lang:masterfrom
cjgillot:nospan-small
Closed

Remove Spans from HIR -- 2/N -- Small HIR nodes#73094
cjgillot wants to merge 31 commits into
rust-lang:masterfrom
cjgillot:nospan-small

Conversation

@cjgillot

@cjgillotcjgillot commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Second step in rust-lang/compiler-team#294
Builds on #72878
Split out of #72015

This PR gradually removes spans from HIR nodes with low usage.
Along the way, HIR visiting stops passing the spans to the visitor.

@rust-highfive

rust-highfive commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2020
@cjgillotcjgillot mentioned this pull request Jun 7, 2020
Closed
@cjgillot

cjgillot commented Jun 7, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @ghost , sorry

@petrochenkovpetrochenkov removed their assignment Jun 7, 2020
@bors

bors commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #72972) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
cjgillotforce-pushed the nospan-small branch 2 times, most recently from 9965b8e to 312c2fbCompareJune 23, 2020 08:10
@bors

bors commented Jun 23, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #73643) made this pull request unmergeable. Please resolve the merge conflicts.

@Muirrum

Muirrum commented Jul 9, 2020

Copy link
Copy Markdown

@rustbot modify labels to: +S-waiting-on-author -S-waiting-on-review

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2020
@bors

bors commented Jul 30, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #74105) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillotcjgillot closed this Oct 4, 2020
@cjgillotcjgillot reopened this Dec 13, 2020
@cjgillot
cjgillotforce-pushed the nospan-small branch 3 times, most recently from 8615229 to 83d33e8CompareDecember 13, 2020 19:05
@cjgillot

cjgillot commented Dec 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2020
@bors

bors commented Dec 21, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #80253) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors

bors commented Dec 25, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #80364) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@cjgillot
cjgillot marked this pull request as ready for review December 25, 2020 18:21
@bors

bors commented Dec 28, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #80439) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Jan 10, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #77862) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon

JohnCSimon commented Jan 25, 2021

Copy link
Copy Markdown

@rustbot label: -S-waiting-on-review +S-waiting-on-author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021
@JohnCSimonJohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2021
@crlf0710

crlf0710 commented Mar 5, 2021

Copy link
Copy Markdown
Member

Triage: I'll mark this as blocked on #72878 for now.

@crlf0710crlf0710 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-blockedStatus: Blocked on something else such as an RFC or other implementation work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjgillot@rust-highfive@bors@Muirrum@JohnCSimon@crlf0710@petrochenkov@rustbot