Add escape_ascii method to u8 and [u8] by clarfonthey · Pull Request #73111 · rust-lang/rust

clarfonthey · 2020-06-08T01:06:36Z

Essentially, this closes an inconsistency gap between char/str and u8/[u8].

Right now the EscapeDefault type used in [u8]::escape_default is exported in core::slice, and it may make sense to move core::ascii::EscapeDefault into core::u8 as well. But for now, this leaves the core::ascii module alone and just calls its methods.

rust-highfive · 2020-06-08T01:06:39Z

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-06-08T04:01:57Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 65'
Agent machine name: 'fv-az578'
Current agent version: '2.169.1'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200517.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200517.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.3)
Checking job knob settings.
Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/49cde91f-1b75-4507-b830-39ab9ff1189a.sh
##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/73111/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/73111/merge:refs/remotes/pull/73111/merge
---
---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS --build=x86_64-unknown-linux-gnu --llvm-root=/usr/lib/llvm-8 --enable-llvm-link-shared --set rust.thin-lto-import-instr-limit=10
---> Using cache
---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy && python2.7 ../x.py test src/test/mir-opt --pass=build --target=armv5te-unknown-linux-gnueabi && python2.7 ../x.py test src/tools/tidy
---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
---> Using cache
---> 091087e35a36
---
Compiling rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
Compiling chalk-rust-ir v0.10.0
Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Compiling chalk-solve v0.10.0
Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
Compiling rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
Compiling chalk-rust-ir v0.10.0
Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Compiling chalk-solve v0.10.0
Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
............................i...............i....................................................... 5200/10285
.................................................................................................... 5300/10285
............................................................................i....................... 5400/10285
......................................................................i............................. 5500/10285
.......................................................................................ii.ii........ 5600/10285
i...i............................................................................................... 5700/10285
......................................i............................................................. 5900/10285
............................................................................................ii...... 6000/10285
...............................i.................................................................... 6100/10285
.................................................................................................... 6200/10285
.................................................................................................... 6200/10285
.................................................................................................... 6300/10285
......................................................ii...i..ii...........i........................ 6400/10285
.................................................................................................... 6600/10285
.................................................................................................... 6700/10285
.................................................................................................... 6700/10285
.......................................................................................i..ii........ 6800/10285
.................................................................................................... 7000/10285
.................................................................................................... 7100/10285
.........................................i.......................................................... 7200/10285
.................................................................................................... 7300/10285
---
.................................................................................................... 8200/10285
.................................................................................................... 8300/10285
................................................................................i................... 8400/10285
.................................................................................................... 8500/10285
..................................iiiiii.iiiiii.i................................................... 8600/10285
.................................................................................................... 8800/10285
.................................................................................................... 8900/10285
.................................................................................................... 9000/10285
.................................................................................................... 9100/10285
---
Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 193 tests
iiii......i..............ii.i..........i......................i...........i..i................i....i 100/193
.............i.i.i...iii..iiiiiiiiiiiiiiiii.......................iii................ii......
finished in 5.532
Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 21 tests
iiiiiiiiiiiiiiiiiiiii
finished in 0.154
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 115 tests
iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
...iiii.....ii.
finished in 15.165
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:695:13
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `2`', src/libstd/sync/mutex.rs:658:13
.....thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:789:13
...thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:765:13
..thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:701:13
thread '.<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:629:13
thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:603:13
thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:616:13
.............................................. 700/769
.........................................thread '<unnamed>' panicked at 'explicit panic', src/libstd/thread/mod.rs:1577:37
---
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
finished in 0.864
Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Testing rustc_query_system stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
Running build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_query_system-2ee1b96c032b758a
running 0 tests
---
Set({"/checkout/src/librustc_parse_format"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_passes"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_plugin_impl"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_privacy"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_save_analysis"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_serialize"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_session"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"/checkout/src/librustc_span"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
---
Rustbook (x86_64-unknown-linux-gnu) - edition-guide
Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
Finished release [optimized] target(s) in 1.84s
std/io/struct.IoSliceMut.html:1285: absolute path - /checkout/src/libcore/std/primitive.u8.html
std/primitive.slice.html:1274: absolute path - /checkout/src/libcore/std/primitive.u8.html
std/vec/struct.Vec.html:2108: absolute path - /checkout/src/libcore/std/primitive.u8.html
core/slice/struct.EscapeDefault.html:2: broken link - core/slice/primitive.slice.html
thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:43:9
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
expected success, got: exit code: 101
---
local time: Mon Jun 8 04:01:50 UTC 2020
network time: Mon, 08 Jun 2020 04:01:50 GMT
== end clock drift check ==
##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/73111/merge to s
Task : Get sources
Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version : 1.0.0
Author : Microsoft
Author : Microsoft
Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/73111/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3464) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Mark-Simulacrum · 2020-06-08T12:38:44Z

I feel like if these don't have ASCII in the name somehow they are quite confusing, and I'm not entirely sure if this is necessary over asking to convert to str and escaping that (perhaps via bstr crate).

clarfonthey · 2020-06-08T22:52:10Z

That's very fair -- I didn't know about the bstr crate, which would be very useful for all sorts of other reasons.

That said, I do think that the remaining method in the ascii module is kind of odd, and it makes much more sense to have it as an inherent method.

So, basically, to me, there are really two options: 1, deprecating in favour of the bstr crate, and 2, some form of this PR.

escape_default does seem like the right name, though, as it does escape into something that can be accepted in a raw string, just as str::escape_default does. That said, we could make it something like escape_ascii_default.

JohnCSimon · 2020-06-16T04:50:43Z

Ping from triage:
@clarfon - friendly reminder that this has sat idle for a week

clarfonthey · 2020-06-18T20:19:17Z

Sorry, I intentionally held off on fixing the code due to @Mark-Simulacrum's concerns about naming. Was going to wait to see if there's a consensus on that before fixing, as I can do both changes at once.

Mark-Simulacrum · 2020-06-18T20:36:17Z

Inherent methods seem reasonable for the ASCII-specific stuff, vs. having free-standing functions in the ASCII module.

I'm going to r? @BurntSushi as this sort of deals with the whole "Unicode" thing and bstr tangentially

Muirrum · 2020-07-24T00:34:32Z

@BurntSushi This is a triage bump.

bors · 2020-07-28T03:06:26Z

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2020-08-11T06:02:59Z

@clarfon
Hello from triage, can you please address the merge conflicts?

clarfonthey · 2020-08-11T07:08:06Z

Will try to get to that soon.

clarfonthey · 2020-08-16T01:11:48Z

Rebased; the current errors appear to be unrelated to this change.

matklad · 2020-08-24T13:10:10Z

hand-wavy concern: I believe all the ascii_xxx methods on u8 ideally should have had self rather than &self argument, to be consistent with all other methods. The reason for &self I believe is historical, dating back to AsciiExt trait.
Should we use &self here to be consistent with other ascii method, or should we use self, to be consistent with non-ascii methods, and with the general pattern that small things are passed by self?

Agree with you, am fine with either convention.

Let's use self here instead of &self. In this case there's not much value in keeping consistency with this historical 'mistake'. (Since some_byte.escape_ascii() will work either way.)

bors · 2020-09-04T14:33:46Z

☔ The latest upstream changes (presumably #75207) made this pull request unmergeable. Please resolve the merge conflicts.

m-ou-se · 2020-12-30T17:05:41Z

Thanks for working on this. I have two small comments left, see above. Other than that, this looks ready to be merged.

m-ou-se · 2020-12-30T17:12:39Z

Oh, one more thing: This now uses both feature = "inherent_ascii_escape" and feature = "inherent_escape_default". I presume you meant to use the same feature name everywhere?

clarfonthey · 2020-12-30T20:46:22Z

Oh, yes, I did. Must have been a find-replace error. Will try and remember to get to this in a few hours when I'm done with work.

camelid · 2021-01-06T20:34:09Z

(I changed the PR title to reflect that it adds escape_ascii, not escape_default.)

clarfonthey · 2021-01-17T04:46:15Z

Finally got to this and rebased with the feature flag fixed and suggestions applied, although I reworded the [u8] docs to be more consistent with the u8 docs.

rust-log-analyzer · 2021-01-17T05:18:40Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 29 tests
iiiiiiiiiiiiiiiiiiiiiiiiiiiii
finished in 0.066 seconds
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 116 tests
iiiiiiiiii.i.i..i..i..ii....i.i....ii..........iiii.........i.....i...i.......ii.i.ii.....iiii.....i 100/116
test result: ok. 78 passed; 0 failed; 38 ignored; 0 measured; 0 filtered out; finished in 2.21s
finished in 2.275 seconds
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
---
Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
Compiling once_cell v1.4.1
Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
Finished release [optimized] target(s) in 1.62s
core/slice/struct.EscapeAscii.html:5: broken intra-doc link - [<code>[u8]::escape_ascii</code>]
core/slice/struct.EscapeAscii.html:7: broken intra-doc link - [<code>[u8]::escape_ascii</code>]
thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:111:9
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
expected success, got: exit code: 101

Co-authored-by: Camelid <camelidcamel@gmail.com>

rust-log-analyzer · 2021-01-17T20:23:26Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 29 tests
iiiiiiiiiiiiiiiiiiiiiiiiiiiii
finished in 0.073 seconds
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 116 tests
iiiiiiiiii.i.i..i..i..ii....i.i....ii..........iiii.........i.....i...i.......ii.i.ii.....iiii.....i 100/116
test result: ok. 78 passed; 0 failed; 38 ignored; 0 measured; 0 filtered out; finished in 2.33s
finished in 2.408 seconds
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
---
Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
Compiling once_cell v1.4.1
Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
Finished release [optimized] target(s) in 1.93s
core/slice/struct.EscapeAscii.html:5: broken intra-doc link - [<code>[u8]::escape_ascii</code>]
core/slice/struct.EscapeAscii.html:7: broken intra-doc link - [<code>[u8]::escape_ascii</code>]
thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:111:9
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
expected success, got: exit code: 101

Co-authored-by: Camelid <camelidcamel@gmail.com>

rust-log-analyzer · 2021-01-18T01:30:13Z

The job mingw-check failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

configure: rust.channel := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions := True
configure: dist.missing-tools := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: configure: run `python /checkout/x.py --help`
configure: ---
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Finished release [optimized] target(s) in 0.17s
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Documenting core v0.0.0 (/checkout/library/core)
error: unresolved link to `slice::escape_ascii`
--> library/core/src/slice/ascii.rs:90:60
|
90 | /// This `struct` is created by the [`[u8]::escape_ascii`](slice::escape_ascii)
| ^^^^^^^^^^^^^^^^^^^ no item named `slice` in scope
|
= note: `-D broken-intra-doc-links` implied by `-D warnings`
error: unresolved link to `slice::escape_ascii`
--> library/core/src/slice/ascii.rs:90:60
|
90 | /// This `struct` is created by the [`[u8]::escape_ascii`](slice::escape_ascii)
| ^^^^^^^^^^^^^^^^^^^ no item named `slice` in scope
error: aborting due to 2 previous errors
error: could not document `core`
Caused by:
process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-type lib --crate-name core library/core/src/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/doc --error-format=json --json=diagnostic-rendered-ansi --markdown-css rust.css --markdown-no-toc -Z unstable-options --resource-suffix 1.51.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/release/deps --cfg=bootstrap -Dwarnings -Winvalid_codeblock_attributes --crate-version '1.51.0-nightly
(8feb86ab6
2021-01-18)'` (exit code: 1)
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "-p" "core" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "-Z" "unstable-options" "--resource-suffix" "1.51.0" "--index-page" "/checkout/src/doc/index.md"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc --stage 0 library/std
Build completed unsuccessfully in 0:00:10

camelid · 2021-01-18T02:06:17Z

Hmm, I'm not sure why the intra-doc links aren't resolving...

clarfonthey · 2021-01-18T05:23:03Z

Pretty sure it's because slice doesn't work in intra-rustdoc links. Will try and fix later.

camelid · 2021-01-18T17:27:58Z

slice should work though: #80181

camelid · 2021-02-12T04:55:49Z

What is the status of this?

Dylan-DPC-zz · 2021-02-13T01:49:30Z

@clarfonthey
thanks for taking the time to contribute. I have to close this due to inactivity. If you wish and you have the time you can open a new PR with these changes and we'll take it from there. Thanks

escape_ascii take 2 The previous PR, rust-lang#73111 was closed for inactivity; since I've had trouble in the past reopening closed PRs, I'm just making a new one. I'm still running the tests locally but figured I'd open the PR in the meantime. Will fix whatever errors show up so we don't have to wait again for this. r? `@m-ou-se`

escape_ascii take 2 The previous PR, rust-lang#73111 was closed for inactivity; since I've had trouble in the past reopening closed PRs, I'm just making a new one. I'm still running the tests locally but figured I'd open the PR in the meantime. Will fix whatever errors show up so we don't have to wait again for this. r? ``@m-ou-se``

escape_ascii take 2 The previous PR, rust-lang#73111 was closed for inactivity; since I've had trouble in the past reopening closed PRs, I'm just making a new one. I'm still running the tests locally but figured I'd open the PR in the meantime. Will fix whatever errors show up so we don't have to wait again for this. r? `@m-ou-se`

escape_ascii take 2 The previous PR, rust-lang#73111 was closed for inactivity; since I've had trouble in the past reopening closed PRs, I'm just making a new one. I'm still running the tests locally but figured I'd open the PR in the meantime. Will fix whatever errors show up so we don't have to wait again for this. r? ``@m-ou-se``

rust-highfive assigned LukasKalbertodt Jun 8, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2020

clarfonthey force-pushed the escape branch from d8a3523 to c277518Compare June 8, 2020 02:27

LeSeulArtichaut added needs-rfc This change is large or controversial enough that it should have an RFC accepted before doing it. T-libs-api [DEPRECATED; DO NOT USE] labels Jun 8, 2020

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2020

rust-highfive assigned BurntSushi and unassigned LukasKalbertodt Jun 18, 2020

Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2020

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020

clarfonthey force-pushed the escape branch 3 times, most recently from d5dc387 to 4745f42Compare August 15, 2020 21:10

matklad reviewed Aug 24, 2020
View reviewed changes

camelid changed the title ~~Add escape_default method to u8 and [u8]~~Add escape_ascii method to u8 and [u8]Jan 6, 2021

camelid reviewed Jan 6, 2021
View reviewed changes

Add escape_default method to u8 and [u8]
35ea315

clarfonthey force-pushed the escape branch from d66f3dd to 35ea315Compare January 17, 2021 04:46

camelid reviewed Jan 17, 2021
View reviewed changes

Comment threadlibrary/core/src/slice/ascii.rs Outdated

Update library/core/src/slice/ascii.rs
34f34dd
Co-authored-by: Camelid <camelidcamel@gmail.com>

camelid reviewed Jan 17, 2021
View reviewed changes

Comment threadlibrary/core/src/slice/ascii.rs Outdated

Update library/core/src/slice/ascii.rs
c7bcf1e
Co-authored-by: Camelid <camelidcamel@gmail.com>

Dylan-DPC-zz added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2021

Dylan-DPC-zz closed this Feb 13, 2021

clarfonthey mentioned this pull request Mar 14, 2021
escape_ascii take 2 #83130
Merged

Mark-Simulacrum mentioned this pull request Feb 12, 2022
Stabilise inherent_ascii_escape (FCP in #77174) #93886
Merged

Uh oh!

Uh oh!

Conversation

clarfonthey commented Jun 8, 2020

Uh oh!

rust-highfive commented Jun 8, 2020

Uh oh!

rust-highfive commented Jun 8, 2020

Uh oh!

Mark-Simulacrum commented Jun 8, 2020

Uh oh!

clarfonthey commented Jun 8, 2020

Uh oh!

JohnCSimon commented Jun 16, 2020

Uh oh!

clarfonthey commented Jun 18, 2020

Uh oh!

Mark-Simulacrum commented Jun 18, 2020

Uh oh!

Muirrum commented Jul 24, 2020

Uh oh!

bors commented Jul 28, 2020

Uh oh!

JohnCSimon commented Aug 11, 2020

Uh oh!

clarfonthey commented Aug 11, 2020

Uh oh!

clarfonthey commented Aug 16, 2020

Uh oh!

matkladAug 24, 2020

Choose a reason for hiding this comment

Uh oh!

clarfontheyAug 25, 2020

Choose a reason for hiding this comment

Uh oh!

m-ou-seDec 30, 2020

Choose a reason for hiding this comment

Uh oh!

bors commented Sep 4, 2020

Uh oh!

m-ou-se commented Dec 30, 2020

Uh oh!

m-ou-se commented Dec 30, 2020

Uh oh!

clarfonthey commented Dec 30, 2020

Uh oh!

camelid commented Jan 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clarfonthey commented Jan 17, 2021

Uh oh!

rust-log-analyzer commented Jan 17, 2021

Uh oh!

Uh oh!

rust-log-analyzer commented Jan 17, 2021

Uh oh!

Uh oh!

rust-log-analyzer commented Jan 18, 2021

Uh oh!

camelid commented Jan 18, 2021

Uh oh!

clarfonthey commented Jan 18, 2021

Uh oh!

camelid commented Jan 18, 2021

Uh oh!

camelid commented Feb 12, 2021

Uh oh!

Dylan-DPC-zz commented Feb 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development