Skip to content

Ensure std benchmarks get tested. - #73142

Merged
bors merged 2 commits into
rust-lang:masterfrom
ehuss:std-benches
Jun 19, 2020
Merged

Ensure std benchmarks get tested.#73142
bors merged 2 commits into
rust-lang:masterfrom
ehuss:std-benches

Conversation

@ehuss

@ehussehuss commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes#54176
Closes#61913

@rust-highfive

rust-highfive commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2020
dtolnay
dtolnay approved these changes Jun 8, 2020
View reviewed changes

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #54176, x.py bench has broken several times, so this seems worthwhile to cover in CI. Thanks!

@dtolnay

dtolnay commented Jun 8, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit bbb3321 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2020
@RalfJung

RalfJung commented Jun 15, 2020

Copy link
Copy Markdown
Member

@bors rollup

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
@Dylan-DPC
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
9688319
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
@Dylan-DPC
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
4012e45
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
@Dylan-DPC
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
00315da
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 15, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 16, 2020
@Manishearth
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
d5dc79d
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@ManishearthManishearth mentioned this pull request Jun 16, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 16, 2020
@Manishearth
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
6f2c37a
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@ManishearthManishearth mentioned this pull request Jun 16, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Jun 17, 2020
@tmandry
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
a37e271
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@tmandrytmandry mentioned this pull request Jun 17, 2020
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 18, 2020
@RalfJung
Rollup merge ofrust-lang#73142- ehuss:std-benches, r=dtolnay
d67e993
Ensure std benchmarks get tested.
This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
Closesrust-lang#54176Closesrust-lang#61913
@RalfJungRalfJung mentioned this pull request Jun 18, 2020
Closed
@RalfJung

RalfJung commented Jun 18, 2020

Copy link
Copy Markdown
Member

Failed in #73470; see build log

 Running build/x86_64-unknown-linux-gnu/stage2-std/wasm32-unknown-unknown/release/deps/coretests-4730807b7cd5cc26.wasm
Running build/x86_64-unknown-linux-gnu/stage2-std/wasm32-unknown-unknown/release/deps/corebenches-363dc139d3325bd1.wasm
RuntimeError: unreachable
at __rust_start_panic (wasm-function[1168]:1)
at rust_panic (wasm-function[1156]:39)
at _ZN3std9panicking20rust_panic_with_hook17h4caac20c72d75dc1E (wasm-function[1151]:279)
at _ZN3std9panicking11begin_panic17h0bae38d50d36d9eeE (wasm-function[1034]:55)
at _ZN3std3sys4wasm4time7Instant3now17he17d4f43932bec50E (wasm-function[1132]:15)
at _ZN3std4time7Instant3now17h3e49cc4c147b1168E (wasm-function[1126]:1)
at _ZN4test5bench13ns_iter_inner17hd2aa5a154314b7aaE (wasm-function[126]:26)
at _ZN4test5bench7Bencher4iter17hd48f4aeafd101cecE (wasm-function[333]:622)
at _ZN4core3ops8function6FnOnce9call_once17hbb5613d41d821ee3E (wasm-function[593]:23)
at _ZN4test28__rust_begin_short_backtrace17hcf6eae0a01d6856fE (wasm-function[791]:11)
at _ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17h1299187062a5e60cE (wasm-function[790]:76)
at _ZN4test28__rust_begin_short_backtrace17heeb3fc1ca1e28307E (wasm-function[795]:10)
at _ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17h989be548adadda66E (wasm-function[794]:11)
at _ZN4test8run_test14run_test_inner17h8475abccc200e35fE (wasm-function[911]:2059)
at _ZN4test8run_test17h8f7c713e96afa866E (wasm-function[867]:4672)
at _ZN4test7console17run_tests_console17h4fdd5ee55c71f0b9E (wasm-function[860]:13898)
at _ZN4test9test_main17hc4961888722dea66E (wasm-function[909]:332)
at _ZN4test16test_main_static17h8622e732a3fec2c9E (wasm-function[910]:356)
at _ZN11corebenches4main17h83609ba82c495beaE (wasm-function[670]:10)
at _ZN3std2rt10lang_start28_$u7b$$u7b$closure$u7d$$u7d$17h797ebef26866c867E (wasm-function[688]:25)
error: test failed, to rerun pass '-p core --bench corebenches'

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 18, 2020
@ehuss

ehuss commented Jun 18, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

TIL wasm doesn't support benchmarks.

@dtolnay I have disabled the benchmarks for wasm32. I have tested locally with the test-various job (wasm32-unknown-unknown, nvptx64-nvidia-cuda, and various musl targets) and armhf-gnu and arm-android.

@dtolnay

dtolnay commented Jun 18, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5a9ff05 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2020
@RalfJungRalfJung mentioned this pull request Jun 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2020
@bors
Auto merge ofrust-lang#73498- RalfJung:rollup-1mfjcju, r=RalfJung
63b441a
Rollup of 13 pull requests
Successful merges:
- rust-lang#70740 (Enabling static-pie for musl)
- rust-lang#72331 (Report error when casting an C-like enum implementing Drop)
- rust-lang#72486 (Fix asinh of negative values)
- rust-lang#72497 (tag/niche terminology cleanup)
- rust-lang#72999 (Create self-contained directory and move there some of external binaries/libs)
- rust-lang#73130 (Remove const prop for indirects)
- rust-lang#73142 (Ensure std benchmarks get tested.)
- rust-lang#73305 (Disallow loading crates with non-ascii identifier name.)
- rust-lang#73346 (Add rust specific features to print target features)
- rust-lang#73362 (Test that bounds checks are elided when slice len is checked up-front)
- rust-lang#73459 (Reduce pointer casts in Box::into_boxed_slice)
- rust-lang#73464 (Document format correction)
- rust-lang#73479 (Minor tweaks to liballoc)
Failed merges:
r? @ghost
@bors
bors merged commit 78f3e9c into rust-lang:masterJun 19, 2020
@tmiaskotmiasko mentioned this pull request Jun 20, 2020
Closed
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnaydtolnaydtolnay approved these changes

Assignees

@dtolnaydtolnay

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

x.py test --no-doc enables testing benchmarks have a travis job that makes sure benchmarks don't break

6 participants

@ehuss@rust-highfive@dtolnay@bors@RalfJung@cuviper