Skip to content

lint: normalize projections using opaque types - #73287

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-73251-opaque-types-in-projections
Jun 21, 2020
Merged

lint: normalize projections using opaque types#73287
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-73251-opaque-types-in-projections

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Fixes#73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2020
@estebank

Copy link
Copy Markdown
Contributor

Needs ./x.py fmt.

r=me after that

@davidtwco
davidtwcoforce-pushed the issue-73251-opaque-types-in-projections branch from 8eb731a to 86c5aacCompareJune 12, 2020 18:27
@davidtwco

Copy link
Copy Markdown
MemberAuthor

Oops, fixed, will r=you after CI passes.

@rust-highfive

This comment has been minimized.

@davidtwco
davidtwcoforce-pushed the issue-73251-opaque-types-in-projections branch from 86c5aac to 4ff1678CompareJune 13, 2020 15:50
@davidtwco

Copy link
Copy Markdown
MemberAuthor

Pushed a minor commit re-wording to re-trigger CI as the last failure was spurious.

@davidtwco

Copy link
Copy Markdown
MemberAuthor

@bors r=estebank

@bors

bors commented Jun 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4ff1678 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 14, 2020
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixesrust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixesrust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixesrust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
@Dylan-DPC-zz

Copy link
Copy Markdown

failed in rollup ci

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2020
@davidtwco
davidtwcoforce-pushed the issue-73251-opaque-types-in-projections branch from 4ff1678 to 792bd3bCompareJune 16, 2020 09:46
@davidtwcodavidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 16, 2020
@davidtwco

Copy link
Copy Markdown
MemberAuthor

@bors r=estebank

@bors

bors commented Jun 16, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 792bd3b has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 19, 2020
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixesrust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
@bors

This comment has been minimized.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2020
This commit normalizes projections which contain opaque types (opaque types
are otherwise linted against, which is would have previously made the
test cases added in this commit fail).
Signed-off-by: David Wood <david@davidtw.co>
@davidtwco
davidtwcoforce-pushed the issue-73251-opaque-types-in-projections branch from 792bd3b to 2e781ddCompareJune 20, 2020 11:07
@davidtwcodavidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2020
@davidtwco

Copy link
Copy Markdown
MemberAuthor

@bors r=estebank

@bors

bors commented Jun 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2e781dd has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 20, 2020
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixesrust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
This was referenced Jun 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2020
…arth
Rollup of 9 pull requests
Successful merges:
- rust-lang#72456 (Try to suggest dereferences on trait selection failed)
- rust-lang#72788 (Projection bound validation)
- rust-lang#72790 (core/time: Add Duration methods for zero)
- rust-lang#73227 (Allow multiple `asm!` options groups and report an error on duplicate options)
- rust-lang#73287 (lint: normalize projections using opaque types)
- rust-lang#73291 (Pre-compute `LocalDefId` <-> `HirId` mappings and remove `NodeId` <-> `HirId` conversion APIs)
- rust-lang#73378 (Remove use of specialization from librustc_arena)
- rust-lang#73411 (Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15))
- rust-lang#73443 (ci: allow gating GHA on everything but macOS)
Failed merges:
r? @ghost
@bors
bors merged commit 9003087 into rust-lang:masterJun 21, 2020
@davidtwco
davidtwco deleted the issue-73251-opaque-types-in-projections branch June 25, 2020 11:09
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improper_ctypes incorrectly warns on projections featuring opaque types

6 participants

@davidtwco@rust-highfive@estebank@bors@Dylan-DPC-zz@cuviper