Uh oh!
There was an error while loading. Please reload this page.
Make novel structural match violations not a bug - #73446
Merged
Merged
Conversation
pnkfelix
commented
Jun 17, 2020
Contributor
Should the warning text reference some issue for further info? |
ecstatic-morse
commented
Jun 17, 2020
ContributorAuthor
Done. See #73448. |
pnkfelix
commented
Jun 17, 2020
Contributor
As discussed in private with @ecstatic-morse , i cannot immediately tell if this represents a hole in the structural-match check that we will need to plug (and thus maybe we should have something stronger than a But it probably isn't worth the effort of putting in the plumbing to issue a proper lint warning here; instead effort should be focused on fixing #73448 itself. and in any case, this PR as it stands fixes the ICE, which trumps all else at the moment. @bors r+ |
bors
commented
Jun 17, 2020
Collaborator
📌 Commit 3a1207f has been approved by |
pnkfelix
commented
Jun 17, 2020
Contributor
unilaterally accepting for beta-backport. |
giving this priority since it is a |
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jun 17, 2020
Make novel structural match violations not a `bug` Fixes (on master) rust-lang#73431. Ideally, `CustomEq` would emit a strict subset of the structural match errors that are found by `search_for_structural_match_violation`, since it allows more cases due to value-based reasoning. However, const qualification is more conservative than `search_for_structural_match_violation` around associated constants, since qualification does not try to substitute type parameters. In the long term, we should probably make const qualification work for generic associated constants, but I don't like extending its capabilities even further. r? @pnkfelix
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Jun 18, 2020
Make novel structural match violations not a `bug` Fixes (on master) rust-lang#73431. Ideally, `CustomEq` would emit a strict subset of the structural match errors that are found by `search_for_structural_match_violation`, since it allows more cases due to value-based reasoning. However, const qualification is more conservative than `search_for_structural_match_violation` around associated constants, since qualification does not try to substitute type parameters. In the long term, we should probably make const qualification work for generic associated constants, but I don't like extending its capabilities even further. r? @pnkfelix
bors
commented
Jun 18, 2020
Collaborator
⌛ Testing commit 3a1207f with merge 205c00429373b16ac70c645031eabc44fe4c8232... |
RalfJung
commented
Jun 18, 2020
Member
Yielding to rollup |
bors
commented
Jun 18, 2020
Collaborator
⌛ Testing commit 3a1207f with merge 493d2a798de149fba00e07f2fb8f0f25f562b760... |
RalfJung
commented
Jun 18, 2020
Member
@bors retry |
bors
commented
Jun 18, 2020
Collaborator
⌛ Testing commit 3a1207f with merge b7a9cf51cc76a4992329c385a49862503e968c3e... |
bors
commented
Jun 18, 2020
Collaborator
💥 Test timed out |
Dylan-DPC-zz
commented
Jun 18, 2020
@bors retry p=5 |
bors
commented
Jun 18, 2020
Collaborator
bors
commented
Jun 19, 2020
Collaborator
☀️ Test successful - checks-azure |
Merged
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2020
…ulacrum [beta] backports This PR backports the following: * Make novel structural match violations not a `bug` rust-lang#73446 * linker: Never pass `-no-pie` to non-gnu linkers rust-lang#73384 * Disable the `SimplifyArmIdentity` pass rust-lang#73262 * Allow inference regions when relating consts rust-lang#73225 * Fix link error with #[thread_local] introduced by rust-lang#71192rust-lang#73065 * Ensure stack when building MIR for matches rust-lang#72941 * Don't create impl candidates when obligation contains errors rust-lang#73005 r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (on master) #73431.
Ideally,
CustomEqwould emit a strict subset of the structural match errors that are found bysearch_for_structural_match_violation, since it allows more cases due to value-based reasoning. However, const qualification is more conservative thansearch_for_structural_match_violationaround associated constants, since qualification does not try to substitute type parameters.In the long term, we should probably make const qualification work for generic associated constants, but I don't like extending its capabilities even further.
r? @pnkfelix