Uh oh!
There was an error while loading. Please reload this page.
Improve document for Result::as_deref(_mut) methods - #73447
Merged
Conversation
Contributor
... |
dtolnay
requested changes
Jun 17, 2020
dtolnay
left a comment
Member
There was a problem hiding this comment.
I would prefer to do this on the tracking issue since there has been quite a bit of participation from stakeholders there.
Could you update the PR to keep just the documentation changes? We can follow up with a separate stabilization PR after FCP.
tesujiforce-pushed
the
stabilize-result_as_deref
branch
from
June 18, 2020 02:07
b61ac86 to
0782aeeCompareResult::as_deref(_mut) methodsResult::as_deref(_mut) methodstesuji
commented
Jun 18, 2020
ContributorAuthor
Sure. Done. |
tesujiforce-pushed
the
stabilize-result_as_deref
branch
from
June 18, 2020 02:10
0782aee to
4e77214Comparedtolnay
commented
Jun 18, 2020
Member
@bors r+ rollup |
bors
commented
Jun 18, 2020
Collaborator
📌 Commit 4e77214 has been approved by |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Jun 18, 2020
…=dtolnay Improve document for `Result::as_deref(_mut)` methods cc rust-lang#50264
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2020
…arth Rollup of 17 pull requests Successful merges: - rust-lang#70551 (Make all uses of ty::Error delay a span bug) - rust-lang#71338 (Expand "recursive opaque type" diagnostic) - rust-lang#71976 (Improve diagnostics for `let x += 1`) - rust-lang#72279 (add raw_ref macros) - rust-lang#72628 (Add tests for 'impl Default for [T; N]') - rust-lang#72804 (Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position) - rust-lang#72814 (remove visit_terminator_kind from MIR visitor) - rust-lang#72836 (Complete the std::time documentation to warn about the inconsistencies between OS) - rust-lang#72968 (Only highlight doc search results via mouseover if mouse has moved) - rust-lang#73034 (Export `#[inline]` fns with extern indicators) - rust-lang#73315 (Clean up some weird command strings) - rust-lang#73320 (Make new type param suggestion more targetted) - rust-lang#73361 (Tweak "non-primitive cast" error) - rust-lang#73425 (Mention functions pointers in the documentation) - rust-lang#73428 (Fix typo in librustc_ast docs) - rust-lang#73447 (Improve document for `Result::as_deref(_mut)` methods) - rust-lang#73476 (Added tooltip for should_panic code examples) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #50264