Uh oh!
There was an error while loading. Please reload this page.
Update the doc for std::prelude to the correct behavior - #73484
Merged
Conversation
rust-highfive
commented
Jun 18, 2020
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
ehuss
commented
Jun 18, 2020
Contributor
I don't think this is correct. Name resolution works through a chain of lookups. For example, it will roughly look in order:
where each one can shadow the one below it. I don't think there is an equivalent way to express this through Rust code. Also |
poliorceticsforce-pushed
the
use-prelude-doc
branch
from
June 19, 2020 19:20
23996bd to
8f0bd5fComparesfackler
commented
Jun 19, 2020
Member
@bors r+ rollup |
bors
commented
Jun 19, 2020
Collaborator
📌 Commit 8f0bd5f has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2020
…arth Rollup of 16 pull requests Successful merges: - rust-lang#71420 (Specialization is unsound) - rust-lang#71899 (Refactor `try_find` a little) - rust-lang#72689 (add str to common types) - rust-lang#72791 (update coerce docs and unify relevant tests) - rust-lang#72934 (forbid mutable references in all constant contexts except for const-fns) - rust-lang#73027 (Make `need_type_info_err` more conservative) - rust-lang#73347 (Diagnose use of incompatible sanitizers) - rust-lang#73359 (shim.rs: avoid creating `Call` terminators calling `Self`) - rust-lang#73399 (Clean up E0668 explanation) - rust-lang#73436 (Clean up E0670 explanation) - rust-lang#73440 (Add src/librustdoc as an alias for src/tools/rustdoc) - rust-lang#73442 (pretty/mir: const value enums with no variants) - rust-lang#73452 (Unify region variables when projecting associated types) - rust-lang#73458 (Use alloc::Layout in DroplessArena API) - rust-lang#73484 (Update the doc for std::prelude to the correct behavior) - rust-lang#73506 (Bump Rustfmt and RLS) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#64686.
One line change to ensure the docs are correct about the behavior of the compiler when inserting
std::prelude::v1.I don't think examples are necessary but I can add some (especially those from the original issue) if needed.