Uh oh!
There was an error while loading. Please reload this page.
Add Docker image to run AArch64 Linux tests - #73650
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I'm thinking we might want to make sure that the sccache for aarch64 and x86_64 is always of the same version -- just to avoid potential collisions that aren't properly handled or whatever.
There was a problem hiding this comment.
Hmm, what do you have in mind to check that?
There was a problem hiding this comment.
Oh I just meant that we'd always have the same date for both -- not automatically checking it, but manually enforcing by updating both at the same time.
There was a problem hiding this comment.
We're not running this builder on CI yet, so there is not going to be duplication at least for a little while. Would you be ok if I follow up on sccache in a separate PR? Building it on musl is kinda of a pain, so I'm working on a script.
Mark-Simulacrum
commented
Jun 26, 2020
Modulo the one nit, seems good to me. r=me when ready and nit is resolved |
emilyalbini
commented
Jun 26, 2020
@bors r=Mark-Simulacrum p=1 rollup=never |
bors
commented
Jun 26, 2020
📌 Commit 0c3661e58d81c7bc9170b09f2550131ce9a40cf8 has been approved by |
emilyalbini
commented
Jun 26, 2020
This will cause a rebuild of most of the CI images. |
bors
commented
Jun 27, 2020
⌛ Testing commit 0c3661e58d81c7bc9170b09f2550131ce9a40cf8 with merge 48c74ee23c8fc4714b9b7330c8272f380c130d1c... |
bors
commented
Jun 27, 2020
💔 Test failed - checks-azure |
bors
commented
Jun 27, 2020
☔ The latest upstream changes (presumably #73779) made this pull request unmergeable. Please resolve the merge conflicts. |
emilyalbini
commented
Jun 29, 2020
Fixed the @bors r=Mark-Simulacrum p=1 |
bors
commented
Jun 29, 2020
📌 Commit f7ed57fa3931894390f217a0077fb43d31454667 has been approved by |
bors
commented
Jun 29, 2020
⌛ Testing commit f7ed57fa3931894390f217a0077fb43d31454667 with merge 3fa5b9a7632cff23d9aa5d22dce447ef9d34ecf3... |
bors
commented
Jun 29, 2020
💔 Test failed - checks-azure |
bors
commented
Jul 3, 2020
💥 Test timed out |
emilyalbini
commented
Jul 3, 2020
@bors retry p=1000 |
bors
commented
Jul 3, 2020
⌛ Testing commit 775eeb3 with merge 3d9c4481de234870b4aedee630113c7df21d8566... |
emilyalbini
commented
Jul 3, 2020
The timeout was expected, as this PR had to rebuild the Linux Docker images which take hours to build. Now this should land without any problem. |
bors
commented
Jul 3, 2020
💔 Test failed - checks-actions |
Manishearth
commented
Jul 3, 2020
@bors retry network |
bors
commented
Jul 3, 2020
bors
commented
Jul 4, 2020
☀️ Test successful - checks-actions, checks-azure |
This PR adds a Docker image to run the AArch64 Linux test suite on a native AArch64 host platform, which will be used in the future to run the test suite in our CI. The image will also be useful for ARM folks to ensure internally that the bugfixes they submit work.
This will be the first Docker image designed to run on a non-x86_64 host platform, and to prevent surprising behavior this PR moves all images requiring a x86_64 host in the
src/ci/docker/host-x86_64directory. Paths and scripts are changed accordingly, and a helpful error message is added when someone tries to run an image on the wrong architecture:The old emulated and disabled
aarch64-gnubuilder is also removed in this PR.This PR is best reviewed commit-by-commit.
r? @Mark-Simulacrum