Skip to content

Avoid "whitelist" - #74127

Merged
bors merged 1 commit into
rust-lang:masterfrom
tamird:allowlist
Jul 11, 2020
Merged

Avoid "whitelist"#74127
bors merged 1 commit into
rust-lang:masterfrom
tamird:allowlist

Conversation

@tamird

@tamirdtamird commented Jul 7, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Other terms are more inclusive and precise.

@rust-highfive

rust-highfive commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2020
tesuji
tesuji reviewed Jul 7, 2020
View reviewed changes
Comment threadsrc/ci/docker/host-x86_64/armhf-gnu/vexpress_config Outdated
@ratijas

This comment has been minimized.

Sign in to view
@ratijas

This comment has been minimized.

Sign in to view
@tamird

tamird commented Jul 8, 2020

Copy link
Copy Markdown
ContributorAuthor

The "third party config variable" was a comment.

cc @steveklabnik and @nikomatsakis, I guess. The reaction to this PR demonstrates the reason this sort of change should be made sooner rather than later.

@steveklabnik

steveklabnik commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

r? @rust-lang/compiler

@rust-langrust-lang locked as too heated and limited conversation to collaborators Jul 8, 2020
@BurntSushi

BurntSushi commented Jul 8, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Moderation note: Some of the comments already posted on this PR are completely inappropriate. While dissent is always encouraged, it must be provided in a constructive manner. Mixing it with personal attacks is not constructive and it will not be tolerated in official Rust community spaces.

Given the nature of this PR, I am locking this PR with the intent that relevant stakeholders are given time to decide how they want to handle this first. It looks like that's probably @rust-lang/compiler.

petrochenkov
petrochenkov reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_feature/builtin_attrs.rs Outdated
@tamird
tamirdforce-pushed the allowlist branch 3 times, most recently from 8daa312 to 401670aCompareJuly 8, 2020 13:06
@newpavlovnewpavlov mentioned this pull request Jul 8, 2020
Open
kennytm
kennytm reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_codegen_ssa/back/linker.rs Outdated
Comment threadsrc/librustc_codegen_llvm/attributes.rs Outdated
Comment threadsrc/test/run-make-fulldeps/sysroot-crates-are-unstable/test.py Outdated
Comment threadsrc/tools/clippy/clippy_lints/src/eq_op.rs Outdated
nikomatsakis
nikomatsakis approved these changes Jul 8, 2020
View reviewed changes

@nikomatsakisnikomatsakis left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits, but I am in favor of removing the term "whitelist" and moving to "allowlist" or other more precise terminology (big 👍 to "AssumeUsed" in particular). This doesn't look like it affects any "user visible" flags or anything like that, it's purely internal? (I would want to have some kind of "deprecation" for the old flags if there were any.)

Comment threadsrc/librustc_codegen_llvm/attributes.rs Outdated
Comment threadsrc/librustc_middle/lint.rs Outdated
@tamird
tamirdforce-pushed the allowlist branch 2 times, most recently from 99880e8 to 23f8cacCompareJuly 8, 2020 13:53
wesleywiser
wesleywiser reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_codegen_llvm/llvm_util.rs Outdated
Comment threadsrc/librustc_codegen_llvm/llvm_util.rs Outdated
@tamird
tamirdforce-pushed the allowlist branch 2 times, most recently from 2b8657b to 8081312CompareJuly 8, 2020 15:02
oli-obk
oli-obk reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/bootstrap/doc.rs Outdated
oli-obk
oli-obk reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_codegen_llvm/back/lto.rs Outdated
oli-obk
oli-obk reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_codegen_llvm/back/lto.rs Outdated
oli-obk
oli-obk reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_codegen_ssa/back/linker.rs Outdated
oli-obk
oli-obk reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_expand/base.rs Outdated
oli-obk
oli-obk reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/librustc_metadata/rmeta/decoder.rs Outdated
@oli-obk

oli-obk commented Jul 10, 2020

Copy link
Copy Markdown
Contributor

@bors r+ p=1 (bitrottyish)

@bors

bors commented Jul 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 62cf767 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2020
@Manishearth
Rollup merge ofrust-lang#74127- tamird:allowlist, r=oli-obk
bdbf1e8
Avoid "whitelist"
Other terms are more inclusive and precise.
@ManishearthManishearth mentioned this pull request Jul 10, 2020
Closed
@bors

bors commented Jul 11, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 62cf767 with merge 2bba01db2eec0bab687b341af01c99cb1e7341fd...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 11, 2020
@Manishearth
Rollup merge ofrust-lang#74127- tamird:allowlist, r=oli-obk
54d59f6
Avoid "whitelist"
Other terms are more inclusive and precise.
@ManishearthManishearth mentioned this pull request Jul 11, 2020
Closed
@Manishearth

Manishearth commented Jul 11, 2020

Copy link
Copy Markdown
Member

@bors retry yield

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 11, 2020
@Manishearth
Rollup merge ofrust-lang#74127- tamird:allowlist, r=oli-obk
0997de8
Avoid "whitelist"
Other terms are more inclusive and precise.
@ManishearthManishearth mentioned this pull request Jul 11, 2020
Closed
@tesuji

This comment has been minimized.

Sign in to view
tesuji
tesuji reviewed Jul 11, 2020
View reviewed changes
Comment threadsrc/etc/test-float-parse/runtests.py
whitelist = sys.argv[1:]
if whitelist:
tests = [test for test in tests if test in whitelist]
listed = sys.argv[1:]

@tesujitesujiJul 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listed sound like a bool to me. Could we change it to args or arguments ?

@shirshak55shirshak55Jul 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea listed is abit weird word here args seems reasonable.

@ManishearthManishearth mentioned this pull request Jul 11, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 11, 2020
@bors
Auto merge ofrust-lang#74235- Manishearth:rollup-bgs3q14, r=Manishe…
346aec9
…arth
Rollup of 19 pull requests
Successful merges:
- rust-lang#71322 (Accept tuple.0.0 as tuple indexing (take 2))
- rust-lang#72303 (Add core::future::{poll_fn, PollFn})
- rust-lang#73862 (Stabilize casts and coercions to `&[T]` in const fn)
- rust-lang#73887 (stabilize const mem::forget)
- rust-lang#73989 (adjust ub-enum test to be endianess-independent)
- rust-lang#74045 (Explain effects of debugging options from config.toml)
- rust-lang#74076 (Add `read_exact_at` and `write_all_at` to WASI's `FileExt`)
- rust-lang#74099 (Add VecDeque::range* methods)
- rust-lang#74100 (Use str::strip* in bootstrap)
- rust-lang#74103 (Only add CFGuard on `windows-msvc` targets)
- rust-lang#74109 (Only allow `repr(i128/u128)` on enum)
- rust-lang#74122 (Start-up clean-up)
- rust-lang#74125 (Correctly mark the ending span of a match arm)
- rust-lang#74127 (Avoid "whitelist")
- rust-lang#74129 (:arrow_up: rust-analyzer)
- rust-lang#74135 (Update books)
- rust-lang#74145 (Update rust-installer to latest version)
- rust-lang#74161 (Fix disabled dockerfiles)
- rust-lang#74162 (take self by value in ToPredicate)
Failed merges:
r? @ghost
@SomeRandomGuy81

This comment has been minimized.

Sign in to view
@bors
bors merged commit d2f8c30 into rust-lang:masterJul 11, 2020
@tamird
tamird deleted the allowlist branch July 11, 2020 10:28
@BurntSushi

BurntSushi commented Jul 11, 2020

Copy link
Copy Markdown
Member

Now that the PR has been merged and this PR seems to have attracted trolls, I'm going to lock it for good. As Niko said above, name improvements can be iterated on in follow up PRs.

Thank you to everyone who participated in this PR constructively!

@rust-langrust-lang locked as resolved and limited conversation to collaborators Jul 11, 2020
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wesleywiserwesleywiserwesleywiser left review comments
@ManishearthManishearthManishearth left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments
@kennytmkennytmkennytm left review comments
@nikomatsakisnikomatsakisnikomatsakis approved these changes
@oli-obkoli-obkoli-obk approved these changes
+7 more reviewers
@shirshak55shirshak55shirshak55 left review comments
@ahmedcharlesahmedcharlesahmedcharles left review comments
@pnkfelixpnkfelixpnkfelix left review comments
@taiki-etaiki-etaiki-e left review comments
@ratijasratijasratijas left review comments
@tesujitesujitesuji left review comments
@TyPR124TyPR124TyPR124 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

20 participants

@tamird@rust-highfive@ratijas@steveklabnik@BurntSushi@oli-obk@bors@pnkfelix@ritobanrc@protheory8@newpavlov@eminence@lnicola@BillBarnhill@Pzixel@sschueller@nikomatsakis@yzb3@TyPR124@Manishearth