Uh oh!
There was an error while loading. Please reload this page.
forbid generic params in the type of const params - #74159
Merged
Conversation
rust-highfive
commented
Jul 8, 2020
Contributor
Some changes occurred in diagnostic error codes |
lcnrforce-pushed
the
const-generic-ty-decl
branch
2 times, most recently
from
July 9, 2020 20:28
5dc2fe6 to
bf9142aComparevarkor
commented
Jul 11, 2020
Contributor
I think it'd help to discuss this on Zulip, because there were objections previously to blocking this in name resolution. I also want to figure out where the previous error went missing, because I would have thought it would have been sufficient if it had stayed around. I'll try to look, but I don't have time immediately. |
bors
commented
Jul 14, 2020
Collaborator
☔ The latest upstream changes (presumably #74330) made this pull request unmergeable. Please resolve the merge conflicts. |
varkor
reviewed
Jul 15, 2020
Uh oh!
There was an error while loading. Please reload this page.
varkor
commented
Jul 15, 2020
Contributor
I'm happy with the implementation: I just want to tweak that error message a little bit. |
varkor
commented
Jul 16, 2020
Contributor
@bors r+ Thanks! |
bors
commented
Jul 16, 2020
Collaborator
📌 Commit 09ba0bd has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
forbid generic params in the type of const params implements and closesrust-lang#74152fixesrust-lang#74101, closesrust-lang#71169, fixesrust-lang#73491, closesrust-lang#62878@eddyb and I talked [on zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/type.20of.20const.20parameters/near/203405696) about this and we probably want to also forbid generic consts in the default type of a parameter, e.g. `struct Foo<T, U = [u8; std::mem::size_of::<T>()]>`, this is currently still allowed and I will probably fix that in a followup PR. r? @varkor@eddyb
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
forbid generic params in the type of const params implements and closesrust-lang#74152fixesrust-lang#74101, closesrust-lang#71169, fixesrust-lang#73491, closesrust-lang#62878@eddyb and I talked [on zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/type.20of.20const.20parameters/near/203405696) about this and we probably want to also forbid generic consts in the default type of a parameter, e.g. `struct Foo<T, U = [u8; std::mem::size_of::<T>()]>`, this is currently still allowed and I will probably fix that in a followup PR. r? @varkor@eddyb
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2020
…arth Rollup of 21 pull requests Successful merges: - rust-lang#73566 (Don't run `everybody_loops` for rustdoc; instead ignore resolution errors) - rust-lang#73771 (Don't pollute docs/suggestions with libstd deps) - rust-lang#73794 (Small cleanup for E0705 explanation) - rust-lang#73807 (rustdoc: glue tokens before highlighting) - rust-lang#73835 (Clean up E0710 explanation) - rust-lang#73926 (Ignoring test case: [codegen] repr-transparent-aggregates-1.rs for aarch64) - rust-lang#73981 (Remove some `ignore-stage1` annotations.) - rust-lang#73998 (add regression test for rust-lang#61216) - rust-lang#74140 (Make hir ProjectionKind more precise) - rust-lang#74148 (Move #[doc(alias)] check in rustc) - rust-lang#74159 (forbid generic params in the type of const params) - rust-lang#74171 (Fix 44056 test with debug on macos.) - rust-lang#74221 (Don't panic if the lhs of a div by zero is not statically known) - rust-lang#74325 (Focus on the current file in the source file sidebar) - rust-lang#74359 (rustdoc: Rename internal API fns to `into_string`) - rust-lang#74370 (Reintroduce spotlight / "important traits" feature) - rust-lang#74390 (Fix typo in std::mem::transmute documentation) - rust-lang#74391 (BtreeMap: superficially refactor root access) - rust-lang#74392 (const generics triage) - rust-lang#74397 (Fix typo in the latest release note) - rust-lang#74406 (Set shell for github actions CI) Failed merges: r? @ghost
This was referenced Jul 17, 2020
Merged
Manishearth pushed a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
Closesrust-lang#69414 (no longer ICEs after rust-lang#74159)
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
Add regression test for rust-lang#69414Closesrust-lang#69414 (no longer ICEs after rust-lang#74159)
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
Add regression test for rust-lang#69414Closesrust-lang#69414 (no longer ICEs after rust-lang#74159)
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
Add regression test for rust-lang#69414Closesrust-lang#69414 (no longer ICEs after rust-lang#74159)
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
…-DPC add test for rust-lang#62878 forgot to push this as part of rust-lang#74159 r? @Dylan-DPC
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements and closes#74152
fixes#74101, closes#71169, fixes#73491, closes#62878
@eddyb and I talked on zulip about this and we probably want to also forbid generic consts in the default
type of a parameter, e.g.
struct Foo<T, U = [u8; std::mem::size_of::<T>()]>, this is currently still allowedand I will probably fix that in a followup PR.
r? @varkor@eddyb