Some `Symbol` related improvements by nnethercote · Pull Request #74357 · rust-lang/rust

nnethercote · 2020-07-15T08:20:55Z

These commits make things nicer and avoid some Symbol::as_str() calls.

r? @oli-obk

oli-obk · 2020-07-15T12:33:22Z

r=me with documentation nit resolved.

nnethercote · 2020-07-16T00:09:35Z

@bors r=oli-obk, rollup=iffy

Iffy because it's fairly large.

bors · 2020-07-16T00:09:36Z

📌 Commit b24bcc883ac9b61217c845c7d8baef8c2889ac4f has been approved by oli-obk,

bors · 2020-07-16T00:09:37Z

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

nnethercote · 2020-07-16T00:10:16Z

I don't think this will have a perf effect, but let's check to be sure.

@bors try @rust-timer queue

bors · 2020-07-16T00:10:18Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

rust-timer · 2020-07-16T00:10:18Z

Awaiting bors try build completion

nnethercote · 2020-07-16T00:11:12Z

@bors r-

nnethercote · 2020-07-16T00:11:51Z

@bors try

bors · 2020-07-16T00:12:07Z

⌛ Trying commit b24bcc883ac9b61217c845c7d8baef8c2889ac4f with merge 4d6f6e62bd34546e4c64b9684af62346c5de2858...

bors · 2020-07-16T02:21:22Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: 4d6f6e62bd34546e4c64b9684af62346c5de2858 (4d6f6e62bd34546e4c64b9684af62346c5de2858)

rust-timer · 2020-07-16T02:21:24Z

Queued 4d6f6e62bd34546e4c64b9684af62346c5de2858 with parent 7e11379, future comparison URL.

rust-timer · 2020-07-16T11:21:05Z

Finished benchmarking try commit (4d6f6e62bd34546e4c64b9684af62346c5de2858): comparison url.

oli-obk · 2020-07-16T11:22:37Z

perf looks clean with potential small improvements, just needs a rebase

The `lifetimes` field is always empty. This commit removes it, and renames the type as `Bounds`.

It's equivalent to `Ident::from_str_and_span`. The commit also introduces some more static symbols so that `Ident::new` can be used in various places instead of `Ident::from_str_and_span`. The commit also changes `Path::path` from a `&str` to a `Symbol`, which then allows the lifetime annotation to be removed from `Ty`. Also, the use of `Symbol` in `Bounds` removes the need for its lifetime annotation.

It's intended only for very temporary use.

This replaces the need for the `description` and `details` symbols in `UnsafetyViolation`, which are static. As a result some `Symbol::as_str()` calls are no longer necessary, which is nice.

nnethercote · 2020-07-16T22:31:00Z

I rebase.

@bors r=oli-obk

bors · 2020-07-16T22:31:01Z

📌 Commit a4ba181 has been approved by oli-obk

bors · 2020-07-16T22:31:02Z

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@oli-obk

…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk

@oli-obk

…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk

@oli-obk

…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk

@oli-obk

…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk

@ghost

…arth Rollup of 8 pull requests Successful merges: - rust-lang#73101 (Resolve items for cross-crate imports relative to the original module) - rust-lang#73269 (Enable some timeouts in SGX platform) - rust-lang#74033 (Add build support for Cargo's build-std feature.) - rust-lang#74351 (Do not render unstable items for rustc doc) - rust-lang#74357 (Some `Symbol` related improvements) - rust-lang#74371 (Improve ayu rustdoc theme) - rust-lang#74386 (Add RISC-V GNU/Linux to src/tools/build-manifest as a host platform) - rust-lang#74398 (Clean up E0723 explanation) Failed merges: r? @ghost

rust-highfive assigned oli-obk Jul 15, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2020

oli-obk reviewed Jul 15, 2020
View reviewed changes

Comment threadsrc/librustc_builtin_macros/deriving/generic/ty.rs Outdated

nnethercote force-pushed the symbol-related-improvements branch from 621cc66 to b24bcc8Compare July 16, 2020 00:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 16, 2020

nnethercote added 6 commits July 17, 2020 07:32

Remove unused cx parameter from pathvec_std and path_std.
8e92f4f

Simplify LifetimeBounds.
bccff14
The `lifetimes` field is always empty. This commit removes it, and renames the type as `Bounds`.

Avoid storing SymbolStr in a struct.
002af4d
It's intended only for very temporary use.

Add UnsafetyViolationDetails.
f03c7f8
This replaces the need for the `description` and `details` symbols in `UnsafetyViolation`, which are static. As a result some `Symbol::as_str()` calls are no longer necessary, which is nice.

Remove some Symbol:as_str() calls.
a4ba181

nnethercote force-pushed the symbol-related-improvements branch from b24bcc8 to a4ba181Compare July 16, 2020 22:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2020

Manishearth mentioned this pull request Jul 16, 2020
Rollup of 9 pull requests #74412
Closed

Manishearth mentioned this pull request Jul 16, 2020
Rollup of 9 pull requests #74414
Closed

Manishearth mentioned this pull request Jul 16, 2020
Rollup of 9 pull requests #74415
Closed

This was referenced Jul 17, 2020
Rollup of 8 pull requests #74421
Closed
Rollup of 8 pull requests #74422
Merged

bors merged commit c60b051 into rust-lang:masterJul 17, 2020

nnethercote deleted the symbol-related-improvements branch July 17, 2020 04:32

cuviper added this to the 1.47.0 milestone May 2, 2024

Uh oh!

Uh oh!

Conversation

nnethercote commented Jul 15, 2020

Uh oh!

Uh oh!

oli-obk commented Jul 15, 2020

Uh oh!

nnethercote commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

nnethercote commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

rust-timer commented Jul 16, 2020

Uh oh!

nnethercote commented Jul 16, 2020

Uh oh!

nnethercote commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

rust-timer commented Jul 16, 2020

Uh oh!

rust-timer commented Jul 16, 2020

Uh oh!

oli-obk commented Jul 16, 2020

Uh oh!

nnethercote commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants