Skip to content

Fix search input focus in ayu theme - #74505

Merged
bors merged 1 commit into
rust-lang:masterfrom
Cldfire:fix-search-focus
Jul 21, 2020
Merged

Fix search input focus in ayu theme#74505
bors merged 1 commit into
rust-lang:masterfrom
Cldfire:fix-search-focus

Conversation

@Cldfire

@CldfireCldfire commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

Closes#74496.

Before:

image

After:

image

@rust-highfive

rust-highfive commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2020
@Cldfire

Cldfire commented Jul 19, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

@MajorBreakfast

MajorBreakfast commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

Tiny nit: The border radius on the right seems a bit smaller than the one one the left 😁

@Cldfire

Cldfire commented Jul 19, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Tiny nit: The border radius on the right seems a bit smaller than the one one the left grin

True! This is the same as what the other themes do, though, and oddly enough it doesn't bother me at all, so I'm not interested in changing that here in this PR.

I think it helps differentiate the two types of boxes up there. One is a less important dropdown while the other is for text entry.

@GuillaumeGomez

GuillaumeGomez commented Jul 20, 2020

Copy link
Copy Markdown
Member

It's voluntary: the left is "joined" with the "all crates" dropdown selector (which has rounded border on the left but not on the right). So please don't change it. :)

GuillaumeGomez
GuillaumeGomez reviewed Jul 20, 2020
View reviewed changes
Comment threadsrc/librustdoc/html/static/themes/ayu.css
margin-left: 8px;
}

#crate-search+.search-input:focus {

@GuillaumeGomezGuillaumeGomezJul 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this block shouldn't have existed by itself: it's the same selector as above...

@GuillaumeGomez

GuillaumeGomez commented Jul 20, 2020

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Jul 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit dec7076 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
@ManishearthManishearth mentioned this pull request Jul 20, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2020
@bors
Auto merge ofrust-lang#74569- Manishearth:rollup-hkn5ex9, r=Manishe…
734233d
…arth
Rollup of 13 pull requests
Successful merges:
- rust-lang#72714 (Fix debug assertion in typeck)
- rust-lang#73197 (Impl Default for ranges)
- rust-lang#73323 (wf: check foreign fn decls for well-formedness)
- rust-lang#74051 (disallow non-static lifetimes in const generics)
- rust-lang#74376 (test caching opt_const_param_of on disc)
- rust-lang#74501 (Ayu theme: Use different background color for Run button)
- rust-lang#74505 (Fix search input focus in ayu theme)
- rust-lang#74522 (Update sanitizer docs)
- rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute)
- rust-lang#74552 (Stabilize TAU constant.)
- rust-lang#74555 (Improve "important traits" popup display on mobile)
- rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern)
- rust-lang#74561 (update backtrace-rs)
Failed merges:
r? @ghost
@bors
bors merged commit 6467f6f into rust-lang:masterJul 21, 2020
@Cldfire
Cldfire deleted the fix-search-focus branch March 6, 2021 05:18
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

Ayu theme search bar focus CSS is broken

7 participants

@Cldfire@rust-highfive@MajorBreakfast@GuillaumeGomez@bors@cuviper@nikomatsakis