Skip to content

Stabilize deque_make_contiguous - #74559

Merged
bors merged 3 commits into
rust-lang:masterfrom
jonhoo:stabilize-vecdeque-make_contiguous
Sep 1, 2020
Merged

Stabilize deque_make_contiguous#74559
bors merged 3 commits into
rust-lang:masterfrom
jonhoo:stabilize-vecdeque-make_contiguous

Conversation

@jonhoo

@jonhoojonhoo commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

Closes#70929.

/cc @Amanieu

@rust-highfive

rust-highfive commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2020
@jonhoo

jonhoo commented Jul 20, 2020

Copy link
Copy Markdown
ContributorAuthor

(I cc'ed Amanieu after a brief conversation with him on Zulip where he told me to post this)

@jonhoojonhoo mentioned this pull request Jul 20, 2020
Closed
2 tasks
@AmanieuAmanieu added the T-libs-api [DEPRECATED; DO NOT USE] label Jul 20, 2020
@Amanieu

Amanieu commented Jul 20, 2020

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Jul 20, 2020•
edited by sfackler
Loading

Copy link
Copy Markdown

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 20, 2020
@AmanieuAmanieu assigned Amanieu and unassigned withoutboatsJul 20, 2020
@jonas-schievinkjonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 20, 2020
@jonas-schievinkjonas-schievink added this to the 1.47 milestone Jul 20, 2020
@bors

bors commented Jul 28, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

@jonhoo
jonhooforce-pushed the stabilize-vecdeque-make_contiguous branch from 37bbbae to 2f96ce8CompareJuly 28, 2020 12:37
@jonhoo

jonhoo commented Aug 3, 2020

Copy link
Copy Markdown
ContributorAuthor

Gentle ping on this. Should hopefully not be too controversial, and it'd be great to try to get it onto the release train :)

Mark-Simulacrum
Mark-Simulacrum reviewed Aug 3, 2020
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque.rs
@Amanieu

Amanieu commented Aug 6, 2020

Copy link
Copy Markdown
Member

ping for checkboxes @SimonSapin@withoutboats@sfackler

@jonhoojonhoo mentioned this pull request Aug 10, 2020
Closed
@jonhoo

jonhoo commented Aug 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Another ping for checkboxes @SimonSapin@withoutboats@sfackler — I'd love to see this land in time for the next release window on the 27th!

@rfcbotrfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 21, 2020
@rfcbot

rfcbot commented Aug 21, 2020

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@Dylan-DPC-zzDylan-DPC-zz modified the milestones: 1.47, 1.48Aug 24, 2020
@rfcbotrfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 31, 2020
@rfcbot

rfcbot commented Aug 31, 2020

Copy link
Copy Markdown

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

Amanieu
Amanieu reviewed Sep 1, 2020
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque.rs Outdated
@jonhoo

jonhoo commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

@Amanieu done! Also merged master for good measure.

@dtolnay

dtolnay commented Sep 1, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8b55360 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2020
@bors

bors commented Sep 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8b55360 with merge eb9e7c3...

@bors

bors commented Sep 1, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: dtolnay
Pushing eb9e7c3 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2020
@bors
bors merged commit eb9e7c3 into rust-lang:masterSep 1, 2020
@jonhoo
jonhoo deleted the stabilize-vecdeque-make_contiguous branch September 1, 2020 21:41
@spastorinospastorino removed the to-announce Announce this issue on triage meeting label Sep 2, 2020
@dtolnaydtolnay self-assigned this Mar 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments
@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@dtolnaydtolnaydtolnay approved these changes

Assignees

@AmanieuAmanieu

@dtolnaydtolnay

Labels

disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.merged-by-borsThis PR was explicitly merged by bors.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for fn VecDeque::make_contiguous

11 participants

@jonhoo@rust-highfive@Amanieu@rfcbot@bors@dtolnay@Mark-Simulacrum@spastorino@jonas-schievink@withoutboats@Dylan-DPC-zz