Uh oh!
There was an error while loading. Please reload this page.
Fix tooltip position if the documentation starts with a code block - #74635
Merged
Conversation
rust-highfive
commented
Jul 22, 2020
Contributor
Some changes occurred in HTML/CSS/JS. |
GuillaumeGomezforce-pushed
the
fix-tooltip-pos
branch
from
July 22, 2020 15:19
f26d7ad to
96225b1CompareManishearth
commented
Jul 22, 2020
Member
@bors r+ rollup @GuillaumeGomez can we set highfive to contain all actively reviewing rustdoc team members so that instead of pinging the entire team for each small PR it cycles through? |
bors
commented
Jul 22, 2020
Collaborator
📌 Commit 96225b1 has been approved by |
GuillaumeGomez
commented
Jul 22, 2020
MemberAuthor
Normally it's already set: https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json#L28 Next time I'll just not set a reviewer. |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 22, 2020
…anishearth Fix tooltip position if the documentation starts with a code block Fixesrust-lang#74321. Before:  After:  And in case there is text, it is not being applied:  And on mobile it isn't needed so it's not "activated":  r? @rust-lang/rustdoc
Manishearth
commented
Jul 22, 2020
Member
Oh, lol. Yeah, I think we should @ the entire team for larger PRs. |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 22, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#73655 (va_args implementation for AAPCS.) - rust-lang#73893 (Stabilize control-flow-guard codegen option) - rust-lang#74237 (compiletest: Rewrite extract_*_version functions) - rust-lang#74454 (small coherence cleanup) - rust-lang#74528 (refactor and reword intra-doc link errors) - rust-lang#74568 (Apply rust-lang#66379 to `*mut T` `as_ref`) - rust-lang#74570 (Use forge links for prioritization procedure) - rust-lang#74589 (Update books) - rust-lang#74635 (Fix tooltip position if the documentation starts with a code block) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#74321.
Before:
After:
And in case there is text, it is not being applied:
And on mobile it isn't needed so it's not "activated":
r? @rust-lang/rustdoc