Skip to content

Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x - #74639

Merged
bors merged 1 commit into
rust-lang:masterfrom
msirringhaus:master
Jul 24, 2020
Merged

Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x#74639
bors merged 1 commit into
rust-lang:masterfrom
msirringhaus:master

Conversation

@msirringhaus

@msirringhausmsirringhaus commented Jul 22, 2020

Copy link
Copy Markdown

As discussed in #73782
I've tested these changes on rust 1.43.0 for all the specified archs and used the resulting binaries to bootstrap building rust 1.43.1.
I've also shortly tested these changes on master on ppc64.

@rust-highfive

rust-highfive commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Jul 22, 2020

Copy link
Copy Markdown
Member

r? @cuviper (but seems fine to me)

@cuviper

cuviper commented Jul 22, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Looks fine, but I'm going to test these builds myself before approving.

This doesn't actually include ppc64le though -- that's a separate builder based on CentOS 7 headers for glibc 2.17 and kernel 3.10. Upstream glibc didn't actually support ppc64le until 2.19, but Red Hat backported it. It looks like SUSE added ppc64le support in SLES 12, glibc 2.19 and kernel 3.12, right? So I think that target is fine anyway.

Perhaps you just meant to write "ppc64(be)"? Meaning that big-endian is implied for ppc64...

cuviper
cuviper approved these changes Jul 22, 2020
View reviewed changes

@cuvipercuviper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after we've clarified endianness -- I'd rather not have a misleading commit message in there.

@msirringhausmsirringhaus changed the title Downgrade glibc to 2.11.1 for ppc, ppc64(le) and s390xDowngrade glibc to 2.11.1 for ppc, ppc64 and s390xJul 23, 2020
@msirringhaus

msirringhaus commented Jul 23, 2020

Copy link
Copy Markdown
Author

Whoops, yes you are correct about le being wrong

@cuviper

cuviper commented Jul 23, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e46219c has been approved by cuviper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2020
@bors

bors commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e46219c with merge 0f4b86960d6d15ea0ae6f4fdf1a21657c4a976bc...

@rust-log-analyzer

rust-log-analyzer commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

The job dist-i686-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors

bors commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2020
@cuviper

cuviper commented Jul 23, 2020

Copy link
Copy Markdown
Member
 failed to fetch `https://github.com/rust-lang/crates.io-index`

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2020
@bors

bors commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e46219c with merge 1f0ed71a2bf64b4971878af46a5e0b41dbf2cae0...

@rust-log-analyzer

rust-log-analyzer commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

The job dist-i686-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@cuviper

cuviper commented Jul 23, 2020

Copy link
Copy Markdown
Member

Same -- I'll try again later.

@ehuss

ehuss commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

@bors retry
zlib error

@cuviper

cuviper commented Jul 23, 2020

Copy link
Copy Markdown
Member

@ehuss is this a known/ongoing issue?

@ehuss

ehuss commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

Yep, working on a fix now, closed the tree in the meantime.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jul 24, 2020
@Dylan-DPC
Rollup merge ofrust-lang#74639- msirringhaus:master, r=cuviper
568b989
Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x
As discussed in rust-lang#73782
I've tested these changes on rust 1.43.0 for all the specified archs and used the resulting binaries to bootstrap building rust 1.43.1.
I've also shortly tested these changes on master on ppc64.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jul 24, 2020
Closed
@ManishearthManishearth mentioned this pull request Jul 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2020
@bors
Auto merge ofrust-lang#74724- Manishearth:rollup-plbt8fe, r=Manishe…
fe07ece
…arth
Rollup of 8 pull requests
Successful merges:
- rust-lang#72954 (revise RwLock for HermitCore)
- rust-lang#74367 (Rearrange the pipeline of `pow` to gain efficiency)
- rust-lang#74491 (Optimize away BitAnd and BitOr when possible)
- rust-lang#74639 (Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x)
- rust-lang#74661 (Refactor `region_name`: add `RegionNameHighlight`)
- rust-lang#74692 (delay_span_bug instead of silent ignore)
- rust-lang#74698 (fixed error reporting for mismatched traits)
- rust-lang#74715 (Add a system for creating diffs across multiple mir optimizations.)
Failed merges:
r? @ghost
@bors
bors merged commit a4024ba into rust-lang:masterJul 24, 2020
@cuvipercuviper mentioned this pull request Jul 24, 2020
Merged
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuvipercuvipercuviper approved these changes

Assignees

@cuvipercuviper

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

7 participants

@msirringhaus@rust-highfive@Mark-Simulacrum@cuviper@bors@rust-log-analyzer@ehuss