Uh oh!
There was an error while loading. Please reload this page.
Deprecate linked_list_extras methods. - #74644
Merged
Merged
Conversation
bors
commented
Jul 28, 2020
Collaborator
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
crlf0710
commented
Jul 28, 2020
MemberAuthor
Rebased. |
Amanieu
commented
Jul 28, 2020
Member
@rust-lang/libs Do we want to add a deprecation period for these unstable methods or can we just remove them directly? |
LukasKalbertodt
commented
Jul 28, 2020
Contributor
I think I would prefer having a deprecation period. We did that for |
Amanieu
commented
Jul 29, 2020
Member
@crlf0710 Could you change your PR to deprecate these methods instead of removing them? |
crlf0710
commented
Jul 29, 2020
MemberAuthor
Sure, will do. |
Amanieu
commented
Jul 31, 2020
Member
@bors r+ |
bors
commented
Jul 31, 2020
Collaborator
📌 Commit dc21178 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 31, 2020
Remove `linked_list_extras` methods. Removing these in favor of the `Cursor` API in rust-lang#58533 . Closesrust-lang#27794. r? @Amanieu
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#74644 (Remove `linked_list_extras` methods.) - rust-lang#74968 (Run all tests if have no specified tests) - rust-lang#74982 (1.45.2 release notes) - rust-lang#74984 (Miri: fix ICE when unwinding past topmost stack frame) - rust-lang#74986 (fix part of comparison that would always evaluate to "true", probably an oversight) - rust-lang#74991 (Fix Const-Generic Cycle ICE rust-lang#74199) Failed merges: r? @ghost
bors
commented
Aug 1, 2020
Collaborator
linked_list_extras methods.linked_list_extras methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing these in favor of the
CursorAPI in #58533 .Closes#27794.
r? @Amanieu