Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #74710
Merged
Merged
Conversation
We can deprecate non-stable/unstable items.
This should not be a change in behavior.
Co-authored-by: Cldfire <cldfire@3grid.net>
Ayu has it. Adding similar rule to other themes makes users less surprised and makes GUI more consistent.
…earth Improve doc theme logo display Fixesrust-lang#74350. The first commit cleans up the whitespaces and converts them to tabs. We should definitely write a tidy check for this (will do it in another PR). Screenshots:    r? @lzutao cc @Cldfire
…illaumeGomez Add right border bar to Dark and Light theme Demo: Light theme: rust-lang#74504 (comment) Dark theme: rust-lang#74504 (comment) Ayu theme: rust-lang#74504 (comment)
…=petrochenkov Internally unify rustc_deprecated and deprecated This PR intentionally tries to be "featureless" in that the behavior is not altered for either attribute, though it more clearly exposes cases where that is the case in the code.
Clean up E0724 explanation r? @Dylan-DPC
polymorphize GlobalAlloc::Function this sadly does not change rust-lang#74614 r? @eddyb
Don't ICE on unconstrained anonymous lifetimes inside associated types. Fixesrust-lang#62200. The change here is inspired (copied) by how this case is handled on bare fns at https://github.com/rust-lang/rust/blob/e8b55a4ad230ebec762fdfc4f241ba98a98560af/src/librustc_typeck/astconv.rs#L3083-L3106.
…ulacrum More BTreeMap test cases, some exposing undefined behaviour Gathered from other ongoing PRs and all either blessed or ignored by Miri r? @Mark-Simulacrum
Remove needless unsafety from BTreeMap::drain_filter Remove one piece of unsafe code in the iteration over the iterator returned by BTreeMap::drain_filter. - Changes an explicitly unspecified part of the API: when the user-supplied predicate (or some of BTreeMap's code) panicked, and the caller tries to use the iterator again, we no longer offer the same key/value pair to the predicate again but pretend the iterator has finished. Note that Miri does not find UB in the test case added here with the unsafe code (or without). - Makes the code a little easier on the eyes. - Makes the code a little harder on the CPU: ``` benchcmp c0 c2 --threshold 3 name c0 ns/iter c2 ns/iter diff ns/iter diff % speedup btree::set::clone_100_and_drain_all 2,794 2,900 106 3.79% x 0.96 btree::set::clone_100_and_drain_half 2,604 2,964 360 13.82% x 0.88 btree::set::clone_10k_and_drain_half 287,770 322,755 34,985 12.16% x 0.89 ``` r? @Amanieu
Add missing backticks in diagnostics note
…an-DPC Clean up E0727 explanation r? @Dylan-DPC
Fix ICE while building MIR with type errors See rust-lang#74047 (comment) for background. Replacing a binding with `PatKind::Wild` (introduced in rust-lang#51789 and later refactored in rust-lang#67439) caused an ICE downstream while building MIR. I noticed that taking this code out no longer triggers the ICEs it was added to prevent. I'm not sure what else changed, or if this change is _correct_, but it does seem to be passing ui tests at least. r? @oli-obk cc @estebankFixesrust-lang#74047.
JohnTitor
commented
Jul 24, 2020
MemberAuthor
bors
commented
Jul 24, 2020
Collaborator
📌 Commit 01b069d has been approved by |
JohnTitor
commented
Jul 24, 2020
MemberAuthor
@bors retry |
bors
commented
Jul 24, 2020
Collaborator
bors
commented
Jul 24, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This was referenced Jul 24, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost