Skip to content

Update E0271 explanation - #74712

Merged
bors merged 1 commit into
rust-lang:masterfrom
strom-und-spiele:E0271-cleanup
Aug 9, 2020
Merged

Update E0271 explanation#74712
bors merged 1 commit into
rust-lang:masterfrom
strom-und-spiele:E0271-cleanup

Conversation

@strom-und-spiele

@strom-und-spielestrom-und-spiele commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

When reading the explanation, I got confused by it. I hope the wording is clearer now.

@rust-highfive

rust-highfive commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2020
JohnTitor
JohnTitor requested changes Aug 6, 2020
View reviewed changes
Comment threadsrc/librustc_error_codes/error_codes/E0271.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0271.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0271.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0271.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0271.md Outdated
@JohnTitor

JohnTitor commented Aug 8, 2020

Copy link
Copy Markdown
Member

Thanks! I think it's now good to go, r? @Mark-Simulacrum for another approval.

@Mark-Simulacrum

Mark-Simulacrum commented Aug 8, 2020

Copy link
Copy Markdown
Member

r=me with commits squashed into one

@strom-und-spiele

strom-und-spiele commented Aug 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Sorry I'm not familiar with that r shorthand.
I assume @Mark-Simulacrum is ok with the changes if squashed into one commit.

@strom-und-spiele
Update E0271.md
7e68b7d
remove references to non existing code,
expand solution suggestions
remove unneeded code in solution
@JohnTitor

JohnTitor commented Aug 8, 2020

Copy link
Copy Markdown
Member

"r=me" means "I'll approve it" so you're right :)
@bors r=Mark-Simulacrum rollup=always

@bors

bors commented Aug 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7e68b7d has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2020
@strom-und-spiele

strom-und-spiele commented Aug 8, 2020

Copy link
Copy Markdown
ContributorAuthor

I like how you resolve my question on one line and create another on the line right after. :D

@JohnTitorJohnTitor mentioned this pull request Aug 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2020
@bors
Auto merge ofrust-lang#75308- JohnTitor:rollup-vnnny43, r=JohnTitor
dcf1077
Rollup of 15 pull requests
Successful merges:
- rust-lang#74712 (Update E0271 explanation)
- rust-lang#74842 (adjust remaining targets)
- rust-lang#75151 (Consistent variable name alloc for raw_vec)
- rust-lang#75162 (Fix the documentation for move about Fn traits implementations)
- rust-lang#75248 (Add `as_mut_ptr` to `NonNull<[T]>`)
- rust-lang#75262 (Show multi extension example for Path in doctests)
- rust-lang#75266 (Add safety section to `NonNull::as_*` method docs)
- rust-lang#75284 (Show relative example for Path ancestors)
- rust-lang#75285 (Separate example for Path strip_prefix)
- rust-lang#75287 (Show Path extension example change multi extension)
- rust-lang#75288 (Use assert! for Path exists example to check bool)
- rust-lang#75289 (Remove ambiguity from PathBuf pop example)
- rust-lang#75290 (fix `min_const_generics` version)
- rust-lang#75291 (Clean up E0750)
- rust-lang#75292 (Clean up E0502)
Failed merges:
r? @ghost
@bors
bors merged commit 5bbdc73 into rust-lang:masterAug 9, 2020
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor requested changes

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

7 participants

@strom-und-spiele@rust-highfive@JohnTitor@Mark-Simulacrum@bors@cuviper@eddyb