Uh oh!
There was an error while loading. Please reload this page.
Pull out some duplicated code into a new function - #74737
Merged
Conversation
smmalis37
commented
Jul 25, 2020
ContributorAuthor
Uhhh...@rust-highfive? You ok buddy? |
smmalis37
commented
Jul 25, 2020
ContributorAuthor
Well if the bot's not gonna do it... r? @davidtwco I guess? |
smmalis37
commented
Jul 26, 2020
ContributorAuthor
@rustbot modify labels: S-waiting-on-review |
davidtwco
commented
Jul 26, 2020
Member
@bors r+ |
bors
commented
Jul 26, 2020
Collaborator
📌 Commit 617dd0a has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jul 27, 2020
Pull out some duplicated code into a new function I debated pulling the actual struct_span_err calls into the new method, but I felt like having to pass in multiple arguments for it and wiring up string formatting outweighed the benefits. Viewing the diff with whitespace ignored is recommended.
bors
commented
Jul 27, 2020
Collaborator
bors
commented
Jul 27, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I debated pulling the actual struct_span_err calls into the new method, but I felt like having to pass in multiple arguments for it and wiring up string formatting outweighed the benefits.
Viewing the diff with whitespace ignored is recommended.