Skip to content

Don't italicize comments in ayu theme - #74790

Merged
bors merged 1 commit into
rust-lang:masterfrom
Cldfire:ayu-no-italic-comments
Jul 27, 2020
Merged

Don't italicize comments in ayu theme#74790
bors merged 1 commit into
rust-lang:masterfrom
Cldfire:ayu-no-italic-comments

Conversation

@Cldfire

@CldfireCldfire commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Closes#74770.

Before:

image

After:

image

@rust-highfive

rust-highfive commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

A change occurred in the Ayu theme.

cc @Cldfire

@rust-highfive

rust-highfive commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2020
@Cldfire

Cldfire commented Jul 26, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented Jul 26, 2020

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 51b99d4 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2020
@jyn514jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 27, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 27, 2020
@Manishearth
Rollup merge ofrust-lang#74790- Cldfire:ayu-no-italic-comments, r=G…
90c590f
…uillaumeGomez
Don't italicize comments in ayu theme
Closesrust-lang#74770.
Before:
![image](https://user-images.githubusercontent.com/13814214/88486217-2bf18700-cf4a-11ea-896d-e7787b94e7a7.png)
After:
![image](https://user-images.githubusercontent.com/13814214/88486225-3a3fa300-cf4a-11ea-929f-90461799dc01.png)
@ManishearthManishearth mentioned this pull request Jul 27, 2020
Closed
@JohnTitorJohnTitor mentioned this pull request Jul 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2020
@bors
Auto merge ofrust-lang#74817- JohnTitor:rollup-0fchdye, r=JohnTitor
52d2c7a
Rollup of 6 pull requests
Successful merges:
- rust-lang#74088 (Avoid writes without any data in `Write::write_all_vectored`)
- rust-lang#74598 (Fix sync_once_cell_does_not_leak_partially_constructed_boxes)
- rust-lang#74750 (Clean up some uses of logging in ui tests)
- rust-lang#74783 (python codes cleanup)
- rust-lang#74790 (Don't italicize comments in ayu theme)
- rust-lang#74799 (Fixed typo in `closure`)
Failed merges:
r? @ghost
@bors
bors merged commit 0042e41 into rust-lang:masterJul 27, 2020
@lqdlqd mentioned this pull request Jun 14, 2022
Closed
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

Ayu: Please don't make comment italic. Instead mark it with different color than doc comment.

7 participants

@Cldfire@rust-highfive@GuillaumeGomez@bors@cuviper@nikomatsakis@jyn514