Skip to content

Make rust.use-lld config option work with non MSVC targets - #75111

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:use-lld-option
Aug 4, 2020
Merged

Make rust.use-lld config option work with non MSVC targets#75111
bors merged 1 commit into
rust-lang:masterfrom
mati865:use-lld-option

Conversation

@mati865

@mati865mati865 commented Aug 3, 2020

Copy link
Copy Markdown
Member

Builds fine and passes tests on Linux.
Not overriding use-lld by linker makes sense on those platforms since very old GCC versions don't understand -fuse-ld=lld. This allows pointing to newer GCC or Clang that will know how to call LLD.

@rust-highfive

rust-highfive commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
Mark-Simulacrum
Mark-Simulacrum reviewed Aug 3, 2020
View reviewed changes
Comment threadconfig.toml.example Outdated
@Mark-Simulacrum

Mark-Simulacrum commented Aug 3, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 594f81a has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2020
@bors

bors commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 594f81a with merge 40857b9...

@bors

bors commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 40857b9 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2020
@bors
bors merged commit 40857b9 into rust-lang:masterAug 4, 2020
@mati865
mati865 deleted the use-lld-option branch August 12, 2020 17:00
This was referenced Sep 2, 2020
Merged
Merged
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mati865@rust-highfive@Mark-Simulacrum@bors@cuviper