Skip to content

Hash parent ExpnData - #75134

Merged
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:feature/expn-data-parent-hash
Aug 9, 2020
Merged

Hash parent ExpnData#75134
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:feature/expn-data-parent-hash

Conversation

@Aaron1011

@Aaron1011Aaron1011 commented Aug 4, 2020•
edited by petrochenkov
Loading

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@Aaron1011

Aaron1011 commented Aug 4, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 1f63a6a with merge b68f54c3db341094fe68cb57a71def8afce8fafb...

@bors

bors commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: b68f54c3db341094fe68cb57a71def8afce8fafb (b68f54c3db341094fe68cb57a71def8afce8fafb)

@rust-timer

rust-timer commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Queued b68f54c3db341094fe68cb57a71def8afce8fafb with parent 80f84eb, future comparison URL.

@petrochenkov

petrochenkov commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

r? @petrochenkov

@rust-timer

rust-timer commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit (b68f54c3db341094fe68cb57a71def8afce8fafb): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@petrochenkov

petrochenkov commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1f63a6a has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
@bors

bors commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1f63a6a with merge 543f03d...

@bors

bors commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 543f03d to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2020
@bors
bors merged commit 543f03d into rust-lang:masterAug 9, 2020
@ecstatic-morse

ecstatic-morse commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

Final perf results. A very small regression in instruction counts, as expected.

@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Aaron1011@rust-highfive@rust-timer@bors@petrochenkov@ecstatic-morse@cuviper@varkor