Skip to content

Fix some Clippy warnings in librustc_serialize - #75201

Merged
bors merged 1 commit into
rust-lang:masterfrom
hirrolot:hirrolot/fix-clippy-warnings
Aug 13, 2020
Merged

Fix some Clippy warnings in librustc_serialize#75201
bors merged 1 commit into
rust-lang:masterfrom
hirrolot:hirrolot/fix-clippy-warnings

Conversation

@hirrolot

@hirrolothirrolot commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2020
@jyn514jyn514 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 7, 2020
@varkor

varkor commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Thanks! Sorry for the delay in reviewing.

@bors r+ rollup

@bors

bors commented Aug 12, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8a4fecb has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 13, 2020
@Dylan-DPC
Rollup merge ofrust-lang#75201- Hirrolot:hirrolot/fix-clippy-warnin…
0b08283
…gs, r=varkor
Fix some Clippy warnings in librustc_serialize
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Aug 13, 2020
Closed
@JohnTitorJohnTitor mentioned this pull request Aug 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2020
@bors
Auto merge ofrust-lang#75476- JohnTitor:rollup-ap1rqf1, r=JohnTitor
9aa6cc0
Rollup of 11 pull requests
Successful merges:
- rust-lang#75189 (Fix wasi::fs::OpenOptions to imply write when append is on)
- rust-lang#75201 (Fix some Clippy warnings in librustc_serialize)
- rust-lang#75372 (Fix suggestion to use lifetime in type and in assoc const)
- rust-lang#75400 (Fix minor things in the `f32` primitive docs)
- rust-lang#75449 (add regression test for rust-lang#74739 (mir const-prop bug))
- rust-lang#75451 (Clean up E0751 explanation)
- rust-lang#75455 (Use explicit path link in place for doc in time)
- rust-lang#75457 (Remove some dead variants in LLVM FFI)
- rust-lang#75466 (Move to intra doc links whenever possible within std/src/lib.rs)
- rust-lang#75469 (Switch to intra-doc links in `std/io/mod.rs`)
- rust-lang#75473 (Flip order of const & type)
Failed merges:
r? @ghost
@bors
bors merged commit d0414b5 into rust-lang:masterAug 13, 2020
@hirrolot
hirrolot deleted the hirrolot/fix-clippy-warnings branch August 13, 2020 08:20
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@varkorvarkor

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hirrolot@rust-highfive@varkor@bors@cuviper@jyn514