Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #75215
Closed
JohnTitor wants to merge 15 commits into
Closed
Conversation
This makes it easier to filter toolstate issues by the tool involved.
in {integer}::from_be_bytes and friends.…matsakis compiletest: ignore-endian-big, fixesrust-lang#74829, fixesrust-lang#74885 See discussion on rust-lang#74829 I tested it on a Debian s390x machine, works well.
Add HRTB-related regression test Closesrust-lang#59311 and cc rust-lang#71546 This closes the former but the test is taken from rust-lang#71546 (comment) since it seems they have the same cause and it's simplified.
Fix typo in `librustc_feature/active.rs`
…komatsakis Label rustfmt toolstate issues with A-rustfmt This makes it easier to filter toolstate issues by the tool involved.
…, r=varkor Handle fieldless tuple structs in diagnostic code Fixesrust-lang#75062
…an-DPC Clean up E0746 explanation r? @Dylan-DPC
Note about endianness of returned value of {integer}::from_be_bytes and friends
[`u32::from_be`](https://doc.rust-lang.org/nightly/src/core/num/mod.rs.html#2883-2892) documents about endianness of returned value.
I was confused by endianness of `from_be_bytes` in rust-lang#75086 .JohnTitor
commented
Aug 6, 2020
MemberAuthor
bors
commented
Aug 6, 2020
Collaborator
📌 Commit 15dd907 has been approved by |
JohnTitor
commented
Aug 6, 2020
MemberAuthor
#75206 will be timeout since the macOS builder seems to be re-building LLVM. |
bors
commented
Aug 6, 2020
Collaborator
⌛ Testing commit 15dd907 with merge 82a3c85362b6f68fdea01fe72df98fa5ba770215... |
bors
commented
Aug 6, 2020
Collaborator
💔 Test failed - checks-actions |
JohnTitor
commented
Aug 6, 2020
MemberAuthor
@bors retry |
bors
commented
Aug 6, 2020
Collaborator
⌛ Testing commit 15dd907 with merge 071e1ee9a68ef5160eb6bf32f8abcc1b3f857ad7... |
bors
commented
Aug 6, 2020
Collaborator
💔 Test failed - checks-actions |
JohnTitor
commented
Aug 6, 2020
MemberAuthor
Hmm, the same failure in #75206 occurs again, let the PRs go to see if it's spurious or not... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
librustc_feature/active.rs#75181 (Fix typo inlibrustc_feature/active.rs)Failed merges:
r? @ghost