Skip to content

Fix ICE when using asm! on an unsupported architecture - #75227

Merged
bors merged 1 commit into
rust-lang:masterfrom
Amanieu:fix_asm_arch
Aug 7, 2020
Merged

Fix ICE when using asm! on an unsupported architecture#75227
bors merged 1 commit into
rust-lang:masterfrom
Amanieu:fix_asm_arch

Conversation

@Amanieu

Copy link
Copy Markdown
Member

Fixes#75220

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

I wonder if we should be specifying which targets are supported, but I feel like that would be needlessly noisy (and we might not really have a good list).

@bors r+

@bors

bors commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 9abdb6d has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2020
@Amanieu

Copy link
Copy Markdown
MemberAuthor

The list of supported target is in the unstable book. It's a bit out of date so I will make another PR to update it.

@ManishearthManishearth mentioned this pull request Aug 7, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
…arth
Rollup of 4 pull requests
Successful merges:
- rust-lang#74774 (adds [*mut|*const] ptr::set_ptr_value)
- rust-lang#75079 (Disallow linking to items with a mismatched disambiguator)
- rust-lang#75203 (Make `IntoIterator` lifetime bounds of `&BTreeMap` match with `&HashMap` )
- rust-lang#75227 (Fix ICE when using asm! on an unsupported architecture)
Failed merges:
r? @ghost
@bors
bors merged commit 9ab750d into rust-lang:masterAug 7, 2020
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.45.0 regression asm-related ICE in tests on non-x86

6 participants

@Amanieu@rust-highfive@Mark-Simulacrum@bors@cuviper@ecstatic-morse